Modify ldap_username to be correct in api and make rubocop happy

Author: ManuelMoeri

app/domain/ptime/people_employees.rb

@@ -114,7 +114,7 @@ def person_role_level_id_by_role(role)
     end
 
     def update_person_with_auth_user_id
-      ldap_username = @ptime_employee_attributes[:ldap_username]
+      ldap_username = @ptime_employee_attributes[:ldapname]
       @person.auth_user_id = AuthUser.find_by(ldap_username:)&.id
     end
   end

app/models/auth_user.rb

@@ -6,17 +6,19 @@ class AuthUser < ApplicationRecord
 
   class << self
     def from_omniauth(auth)
-      person = where(uid: auth.uid).first_or_create do |user|
-        user.name = auth.info.name
-        user.email = auth.info.email
-        user.ldap_username = auth.extra.raw_info.pitc.uid
-      end
+      person = where(uid: auth.uid).first_or_create { |user| initialize_user(user, auth) }
       person.last_login = Time.zone.now
       set_admin(person, auth)
     end
 
     private
 
+    def initialize_user(user, auth)
+      user.name = auth.info.name
+      user.email = auth.info.email
+      user.ldap_username = auth.extra.raw_info.pitc.uid
+    end
+
     def set_admin(person, auth)
       person.is_admin = role?(auth, AuthConfig.admin_role)
       person.is_conf_admin = role?(auth, AuthConfig.conf_admin_role)