Feature/947 Every person can edit themselves #1002
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ManuelMoeri
force-pushed
the
feature/946-setup-cancancan
branch
from
0532487 to
83da19f
Compare
ManuelMoeri
force-pushed
the
feature/947-every-person-can-edit-themselves
branch
from
6edce74 to
ba30b19
Compare
RandomTannenbaum
requested changes
Jul 30, 2025
| PersonRoleLevel.find_by(level: role[:role_level])&.id || PersonRoleLevel.first.id | ||
| end | ||
|
|
||
| def update_person_with_auth_user_id |
There was a problem hiding this comment.
Maybe rename this to something like set_auth_user_id_on_person?
|
|
||
| def update_person_with_auth_user_id | ||
| ldap_username = @ptime_employee_attributes[:ldapname] | ||
| @person.auth_user_id = AuthUser.find_by(ldap_username:)&.id |
There was a problem hiding this comment.
Probably use find_by! here so the transaction fails if the AuthUser is not found.
| @@ -0,0 +1,5 @@ | |||
| class AddAuthUserIdToPeople < ActiveRecord::Migration[8.0] | |||
There was a problem hiding this comment.
You could combine both migrations to one
| @@ -0,0 +1,5 @@ | |||
| class AddAuthUserIdToPeople < ActiveRecord::Migration[8.0] | |||
| def change | |||
| add_column :people, :auth_user_id, :integer, foreign_key: { to_table: :people } | |||
There was a problem hiding this comment.
You should probably also add belongs_to and has_one to people and auth_users respectively.
See: https://guides.rubyonrails.org/association_basics.html
|
|
||
| click_link('Bearbeiten', href: edit_person_path(ursula)) | ||
| fill_in 'person_title', with: 'Expert at access control' | ||
| save_button = find_button("Person aktualisieren") |
There was a problem hiding this comment.
There is a click_button method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.