add SingleAxisTracker support to ModelChain #173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code makes it so that you can use a
ModelChain
with aSingleAxisTracker
.It's a bit verbose due to a couple of potentially bad design decisions in
SingleAxisTracker
(overridingPVSystem.get_irradiance
and setting the output ofsingleaxis
tonan
forzenith > 90
). I'd prefer to merge this for a 0.3.3 release and make the API breaking changes in 0.4.The code works and passes a new test, but I want to test it more thoroughly in the next few days. I'll probably merge it on Tuesday or Wednesday unless someone objects.
Closes #169
To do:
mc.tracking
attribute