From ea5cf74917bf23bd97f882dc1283b6e17d216e45 Mon Sep 17 00:00:00 2001 From: Will Hobbs <45701090+williamhobbs@users.noreply.github.com> Date: Fri, 20 Oct 2023 14:12:52 -0500 Subject: [PATCH 1/4] Update plot_singlediode.py fixed plot annotations by moving plt.show() further down --- docs/examples/iv-modeling/plot_singlediode.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/examples/iv-modeling/plot_singlediode.py b/docs/examples/iv-modeling/plot_singlediode.py index c8cbe506ca..1cdda9f348 100644 --- a/docs/examples/iv-modeling/plot_singlediode.py +++ b/docs/examples/iv-modeling/plot_singlediode.py @@ -118,7 +118,6 @@ plt.xlabel('Module voltage [V]') plt.ylabel('Module current [A]') plt.title(parameters['Name']) -plt.show() plt.gcf().set_tight_layout(True) @@ -136,6 +135,7 @@ def draw_arrow(ax, label, x0, y0, rotation, size, direction): ax = plt.gca() draw_arrow(ax, 'Irradiance', 20, 2.5, 90, 15, 'r') draw_arrow(ax, 'Temperature', 35, 1, 0, 15, 'l') +plt.show() print(pd.DataFrame({ 'i_sc': curve_info['i_sc'], From 1c8a589cbb8bb1f69538a70a51e27f8546d93286 Mon Sep 17 00:00:00 2001 From: Will Hobbs <45701090+williamhobbs@users.noreply.github.com> Date: Fri, 20 Oct 2023 14:21:30 -0500 Subject: [PATCH 2/4] Update whatsnew.rst --- docs/sphinx/source/whatsnew.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/sphinx/source/whatsnew.rst b/docs/sphinx/source/whatsnew.rst index 1b19f40ec6..6440aa35fe 100644 --- a/docs/sphinx/source/whatsnew.rst +++ b/docs/sphinx/source/whatsnew.rst @@ -6,6 +6,14 @@ What's New These are new features and improvements of note in each release. +Bug fixes +~~~~~~~~~ +* Fixed a plotting issue in the IV curve gallery example (:pull:`1895`) + +Contributors +~~~~~~~~~~~~ +* Will Hobbs (:ghuser:`williamhobbs`) + .. include:: whatsnew/v0.10.2.rst .. include:: whatsnew/v0.10.1.rst .. include:: whatsnew/v0.10.0.rst From a5774b5c50afec114f4e536782a72b44e5a6780e Mon Sep 17 00:00:00 2001 From: Will Hobbs <45701090+williamhobbs@users.noreply.github.com> Date: Mon, 23 Oct 2023 08:33:04 -0500 Subject: [PATCH 3/4] Update v0.10.3.rst --- docs/sphinx/source/whatsnew/v0.10.3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.10.3.rst b/docs/sphinx/source/whatsnew/v0.10.3.rst index 0853254983..8bdc2cf98f 100644 --- a/docs/sphinx/source/whatsnew/v0.10.3.rst +++ b/docs/sphinx/source/whatsnew/v0.10.3.rst @@ -24,7 +24,7 @@ Testing Documentation ~~~~~~~~~~~~~ - +* Fixed a plotting issue in the IV curve gallery example (:pull:`1895`) Contributors ~~~~~~~~~~~~ From d8fd19109e5ec189e0b9588456a6da42e283f379 Mon Sep 17 00:00:00 2001 From: Will Hobbs <45701090+williamhobbs@users.noreply.github.com> Date: Mon, 23 Oct 2023 09:12:46 -0500 Subject: [PATCH 4/4] Update docs/sphinx/source/whatsnew.rst Undoing changes to whatsnew.rst --- docs/sphinx/source/whatsnew.rst | 8 -------- 1 file changed, 8 deletions(-) diff --git a/docs/sphinx/source/whatsnew.rst b/docs/sphinx/source/whatsnew.rst index 6440aa35fe..1b19f40ec6 100644 --- a/docs/sphinx/source/whatsnew.rst +++ b/docs/sphinx/source/whatsnew.rst @@ -6,14 +6,6 @@ What's New These are new features and improvements of note in each release. -Bug fixes -~~~~~~~~~ -* Fixed a plotting issue in the IV curve gallery example (:pull:`1895`) - -Contributors -~~~~~~~~~~~~ -* Will Hobbs (:ghuser:`williamhobbs`) - .. include:: whatsnew/v0.10.2.rst .. include:: whatsnew/v0.10.1.rst .. include:: whatsnew/v0.10.0.rst