fix dropped nighttime values in perez, propagate airmass to perez in ModelChain #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # var.AM(var.solar_zenith >=90 & var.DHI >0) = 37; | ||
|
|
||
| # var.DNI_ET[var.DNI_ET==0] = .00000001 #very hacky, fix this | ||
|
|
||
| # delta is the sky's "brightness" | ||
| delta = dhi * airmass / dni_extra | ||
|
|
||
| # keep only valid times |
There was a problem hiding this comment.
the ebin.index changes from here to the end of the function are what really matters in this diff.
wholmgren
force-pushed
the
fixampropagation
branch
from
3463207 to
394962e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172 and #191.