From 8faf76a58b3189af92fff7cb88c2c55c2f358078 Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 1 Dec 2023 12:35:21 +0100 Subject: [PATCH 1/2] Fix temp_dew point mapping --- pvlib/iotools/psm3.py | 2 +- pvlib/tests/iotools/test_psm3.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/iotools/psm3.py b/pvlib/iotools/psm3.py index d2d31b1388..35fb2d362b 100644 --- a/pvlib/iotools/psm3.py +++ b/pvlib/iotools/psm3.py @@ -30,7 +30,7 @@ 'Clearsky DNI': 'dni_clear', 'Solar Zenith Angle': 'solar_zenith', 'Temperature': 'temp_air', - 'Dew point': 'temp_dew', + 'Dew Point': 'temp_dew', 'Relative Humidity': 'relative_humidity', 'Pressure': 'pressure', 'Wind Speed': 'wind_speed', diff --git a/pvlib/tests/iotools/test_psm3.py b/pvlib/tests/iotools/test_psm3.py index 41c4be922d..91bba7a830 100644 --- a/pvlib/tests/iotools/test_psm3.py +++ b/pvlib/tests/iotools/test_psm3.py @@ -172,7 +172,7 @@ def test_read_psm3_map_variables(): data, metadata = psm3.read_psm3(MANUAL_TEST_DATA, map_variables=True) columns_mapped = ['Year', 'Month', 'Day', 'Hour', 'Minute', 'dhi', 'ghi', 'dni', 'ghi_clear', 'dhi_clear', 'dni_clear', - 'Cloud Type', 'Dew Point', 'solar_zenith', + 'Cloud Type', 'temp_dew', 'solar_zenith', 'Fill Flag', 'albedo', 'wind_speed', 'wind_direction', 'precipitable_water', 'relative_humidity', 'temp_air', 'pressure'] From 0cf1ed4b2c900bcef51ba12254093c2ee548a99f Mon Sep 17 00:00:00 2001 From: "Adam R. Jensen" <39184289+AdamRJensen@users.noreply.github.com> Date: Fri, 1 Dec 2023 12:39:52 +0100 Subject: [PATCH 2/2] Add whatsnew entry --- docs/sphinx/source/whatsnew.rst | 1 + docs/sphinx/source/whatsnew/v0.10.3.rst | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew.rst b/docs/sphinx/source/whatsnew.rst index 1b19f40ec6..c614c0de98 100644 --- a/docs/sphinx/source/whatsnew.rst +++ b/docs/sphinx/source/whatsnew.rst @@ -6,6 +6,7 @@ What's New These are new features and improvements of note in each release. +.. include:: whatsnew/v0.10.3.rst .. include:: whatsnew/v0.10.2.rst .. include:: whatsnew/v0.10.1.rst .. include:: whatsnew/v0.10.0.rst diff --git a/docs/sphinx/source/whatsnew/v0.10.3.rst b/docs/sphinx/source/whatsnew/v0.10.3.rst index b619271d3b..007eb8d34b 100644 --- a/docs/sphinx/source/whatsnew/v0.10.3.rst +++ b/docs/sphinx/source/whatsnew/v0.10.3.rst @@ -15,7 +15,8 @@ Enhancements Bug fixes ~~~~~~~~~ - +* Fix mapping of the dew point column to ``temp_dew`` when ``map_variables`` + is True in :py:func:`pvlib.iotools.get_psm3`. (:pull:`1920`) Testing ~~~~~~~