From e56498d56787a9c961d7a84b60807e27bd96683d Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Fri, 16 May 2025 11:32:56 +0200 Subject: [PATCH 1/2] Fix typos --- docs/sphinx/source/user_guide/modeling_topics/bifacial.rst | 2 +- docs/sphinx/source/user_guide/modeling_topics/modelchain.rst | 4 ++-- docs/sphinx/source/user_guide/modeling_topics/pvsystem.rst | 2 +- .../sphinx/source/user_guide/modeling_topics/weather_data.rst | 4 ++-- pvlib/iotools/bsrn.py | 2 +- pvlib/iotools/pvgis.py | 2 +- pvlib/iotools/sodapro.py | 4 ++-- pvlib/ivtools/sdm/_fit_desoto_pvsyst_sandia.py | 2 +- pvlib/solarposition.py | 2 +- pvlib/spa_c_files/README.md | 2 +- 10 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/sphinx/source/user_guide/modeling_topics/bifacial.rst b/docs/sphinx/source/user_guide/modeling_topics/bifacial.rst index 0b1b0736a0..e7e943e1ad 100644 --- a/docs/sphinx/source/user_guide/modeling_topics/bifacial.rst +++ b/docs/sphinx/source/user_guide/modeling_topics/bifacial.rst @@ -80,7 +80,7 @@ The model operates in the following steps: determines the fraction of ground-reflected irradiance that reaches the row surface. 4. Find the fraction of the row surface that is shaded from direct irradiance. - Only sky and ground-reflected irradiance reach the the shaded fraction of + Only sky and ground-reflected irradiance reach the shaded fraction of the row surface. 5. For the front and rear surfaces, apply the incidence angle modifier to the direct irradiance and sum the diffuse sky, diffuse ground, and direct diff --git a/docs/sphinx/source/user_guide/modeling_topics/modelchain.rst b/docs/sphinx/source/user_guide/modeling_topics/modelchain.rst index 63a1d0618a..da2fef22d3 100644 --- a/docs/sphinx/source/user_guide/modeling_topics/modelchain.rst +++ b/docs/sphinx/source/user_guide/modeling_topics/modelchain.rst @@ -371,7 +371,7 @@ DC quantities to the output of the full PVSystem. mc.results.dc We’ve established that the ``ModelChain.pvwatts_dc`` and -``ModelChain.sapm`` have the same API: they take the same arugments +``ModelChain.sapm`` have the same API: they take the same arguments (``self``) and they both set the ``dc`` attribute.\* Because the methods have the same API, we can call them in the same way. ModelChain includes a large number of methods that perform the same API-unification roles @@ -489,7 +489,7 @@ Temperature data are passed in the ``weather`` DataFrame and can include: method is used to calculate cell temperature. If ``ModelChain.temperature_model`` is set to any other model, ``'module_temperature'`` is ignored. * ambient air temperature (``'temp_air'``). In this case ``ModelChain.temperature_model`` - is used to calculate cell temeprature. + is used to calculate cell temperature. Cell temperature models also can use irradiance as input. All cell temperature models expect POA irradiance (``'poa_global'``) as input. When diff --git a/docs/sphinx/source/user_guide/modeling_topics/pvsystem.rst b/docs/sphinx/source/user_guide/modeling_topics/pvsystem.rst index c3d666fbfe..0057c66cdd 100644 --- a/docs/sphinx/source/user_guide/modeling_topics/pvsystem.rst +++ b/docs/sphinx/source/user_guide/modeling_topics/pvsystem.rst @@ -240,7 +240,7 @@ operates in a similar manner. The `PVSystem` method :py:meth:`~pvlib.pvsystem.PVSystem.get_aoi` -operates on all `Array` instances in the `PVSystem`, whereas the the +operates on all `Array` instances in the `PVSystem`, whereas the `Array` method operates only on its `Array` instance. .. ipython:: python diff --git a/docs/sphinx/source/user_guide/modeling_topics/weather_data.rst b/docs/sphinx/source/user_guide/modeling_topics/weather_data.rst index 9f983cf335..3d9b0096af 100644 --- a/docs/sphinx/source/user_guide/modeling_topics/weather_data.rst +++ b/docs/sphinx/source/user_guide/modeling_topics/weather_data.rst @@ -35,7 +35,7 @@ them. source of weather information. However, the coverage depends on a weather station having been set up in advance for the location and times of interest. Some ground station networks like the BSRN and SURFRAD - make their measurement data publicly available. An global overview of ground + make their measurement data publicly available. A global overview of ground stations is available at https://SolarStations.org. Data from public ground station measurement networks are useful if you @@ -50,7 +50,7 @@ them. weather station. They have high spatial and temporal resolution corresponding to the source satellite imagery, and are generally optimised to estimate solar irradiance for PV applications. Free sources - such as PVGIS, NSRDB, and CAMS are available, and commerical sources such + such as PVGIS, NSRDB, and CAMS are available, and commercial sources such as SolarAnywhere, Solcast, and Solargis provide paid options though often have free trials. diff --git a/pvlib/iotools/bsrn.py b/pvlib/iotools/bsrn.py index 43fdbe919f..777eab9614 100644 --- a/pvlib/iotools/bsrn.py +++ b/pvlib/iotools/bsrn.py @@ -109,7 +109,7 @@ def get_bsrn(station, start, end, username, password, UserWarning If one or more requested files are missing a UserWarning is returned with a list of the filenames missing. If no files match the specified - station and timeframe a seperate UserWarning is given. + station and timeframe a separate UserWarning is given. Notes ----- diff --git a/pvlib/iotools/pvgis.py b/pvlib/iotools/pvgis.py index 3ab22c1ed8..46406c5a53 100644 --- a/pvlib/iotools/pvgis.py +++ b/pvlib/iotools/pvgis.py @@ -720,7 +720,7 @@ def get_pvgis_horizon(latitude, longitude, url=URL, **kwargs): Returns ------- data : pd.Series - Pandas Series of the retrived horizon elevation angles. Index is the + Pandas Series of the retrieved horizon elevation angles. Index is the corresponding horizon azimuth angles. metadata : dict Metadata returned by PVGIS. diff --git a/pvlib/iotools/sodapro.py b/pvlib/iotools/sodapro.py index b9922af4b8..0aba3c26b3 100644 --- a/pvlib/iotools/sodapro.py +++ b/pvlib/iotools/sodapro.py @@ -202,7 +202,7 @@ def get_cams(latitude, longitude, start, end, email, identifier='mcclear', 'username': email, 'verbose': verbose} - # Manual formatting of the input parameters seperating each by a semicolon + # Manual formatting of the input parameters separating each by a semicolon data_inputs = ";".join([f"{key}={value}" for key, value in data_inputs_dict.items()]) @@ -214,7 +214,7 @@ def get_cams(latitude, longitude, start, end, email, identifier='mcclear', } # The DataInputs parameter of the URL has to be manually formatted and - # added to the base URL as it contains sub-parameters seperated by + # added to the base URL as it contains sub-parameters separated by # semi-colons, which gets incorrectly formatted by the requests function # if passed using the params argument. res = requests.get(base_url + '?DataInputs=' + data_inputs, params=params, diff --git a/pvlib/ivtools/sdm/_fit_desoto_pvsyst_sandia.py b/pvlib/ivtools/sdm/_fit_desoto_pvsyst_sandia.py index e22f3be1ca..55da6e386c 100644 --- a/pvlib/ivtools/sdm/_fit_desoto_pvsyst_sandia.py +++ b/pvlib/ivtools/sdm/_fit_desoto_pvsyst_sandia.py @@ -335,7 +335,7 @@ def _check_converge(prevparams, result, vmp, imp, i): ---------- prevparams: Convergence Parameters from the previous Iteration (used to determine Percent Change in values between iterations) - result: performacne paramters of the (predicted) single diode fitting, + result: performacne parameters of the (predicted) single diode fitting, which includes Voc, Vmp, Imp, Pmp and Isc vmp: measured values for each IV curve imp: measured values for each IV curve diff --git a/pvlib/solarposition.py b/pvlib/solarposition.py index b667ac04e0..7284191d68 100644 --- a/pvlib/solarposition.py +++ b/pvlib/solarposition.py @@ -134,7 +134,7 @@ def spa_c(time, latitude, longitude, pressure=101325., altitude=0., The source files for this code are located in './spa_c_files/', along with a README file which describes how the C code is wrapped in Python. - Due to license restrictions, the C code must be downloaded seperately + Due to license restrictions, the C code must be downloaded separately and used in accordance with it's license. This function is slower and no more accurate than :py:func:`spa_python`. diff --git a/pvlib/spa_c_files/README.md b/pvlib/spa_c_files/README.md index 472fc4b8f8..aaef8bd571 100644 --- a/pvlib/spa_c_files/README.md +++ b/pvlib/spa_c_files/README.md @@ -25,7 +25,7 @@ There are a total of 5 files needed to compile the C code, described below: * `cspa_py.pxd`: a cython header file which essentially tells cython which parts of the main header file to pay attention to * `spa_py.pyx`: the cython code used to define both functions in the python - namespace. NOTE: It is possible to provide user access to other paramters of + namespace. NOTE: It is possible to provide user access to other parameters of the SPA algorithm through modifying this file * `setup.py`: a distutils file which performs the compiling of the cython code From cc542fee0e98803b159e1b22bfbed1dce60f7547 Mon Sep 17 00:00:00 2001 From: omahs <73983677+omahs@users.noreply.github.com> Date: Fri, 16 May 2025 17:01:38 +0200 Subject: [PATCH 2/2] Add omahs as contributor --- docs/sphinx/source/whatsnew/v0.12.1.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/sphinx/source/whatsnew/v0.12.1.rst b/docs/sphinx/source/whatsnew/v0.12.1.rst index 6152f03c7e..856e5fa5d7 100644 --- a/docs/sphinx/source/whatsnew/v0.12.1.rst +++ b/docs/sphinx/source/whatsnew/v0.12.1.rst @@ -66,3 +66,4 @@ Contributors * Kevin Anderson (:ghuser:`kandersolar`) * Will Holmgren (:ghuser:`wholmgren`) * Muhammad Rebaal (:ghuser:`Muhammad-Rebaal`) +* omahs (:ghuser:`omahs`)