Skip to content

Edits for pvlib name, logo, clarify docstrings, correct typos #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

cwhanse
Copy link
Member

@cwhanse cwhanse commented May 3, 2019

pvlib python pull request guidelines

Thank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.

You may submit a pull request with your code at any stage of completion.

The following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:

  • Closes issue #xxxx
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes LGTM and SticklerCI checks.
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

@cwhanse cwhanse added this to the 0.6.2 milestone May 3, 2019
@mikofski
Copy link
Member

mikofski commented May 3, 2019

Hi Cliff, just curious, how is this different from #688 - it looks that was merged already, and this is a spin-off from that branch. Are you planning a few more changes? Did you open this PR by accident?

@cwhanse
Copy link
Member Author

cwhanse commented May 3, 2019

No, bad branch management on my end. I frequently work from both office and home, I must have pushed the branch from home but not cleaned up the office computer.

@cwhanse cwhanse closed this May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants