improve modelchain inference error text #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwhanse
approved these changes
May 3, 2019
pvlib/modelchain.py
Outdated
| @@ -577,7 +582,10 @@ def infer_aoi_model(self): | |||
| return self.ashrae_aoi_loss | |||
| else: | |||
| raise ValueError('could not infer AOI model from ' | |||
| 'system.module_parameters') | |||
| 'system.module_parameters. Check that the ' | |||
| 'parameters contain physical, aoi, or ashrae ' | |||
There was a problem hiding this comment.
system.module_parameters contain parameters for the physical, aoi, or ashrae model; explicitly set model with aoi_model kwarg; or
pvlib/modelchain.py
Outdated
| @@ -629,8 +637,9 @@ def infer_spectral_model(self): | |||
| raise ValueError('could not infer spectral model from ' | |||
| 'system.module_parameters. Check that the ' | |||
| 'parameters contain valid ' | |||
There was a problem hiding this comment.
system.module_parameters contains valid
pvlib/modelchain.py
Outdated
| @@ -411,7 +414,8 @@ def infer_dc_model(self): | |||
| return self.pvwatts_dc, 'pvwatts' | |||
| else: | |||
| raise ValueError('could not infer DC model from ' | |||
| 'system.module_parameters') | |||
| 'system.module_parameters. Check parameters or ' | |||
| 'explicity set model with dc_model kwarg.') | |||
There was a problem hiding this comment.
explicitly set the model with the dc_model kwarg
pvlib/modelchain.py
Outdated
| @@ -530,7 +534,8 @@ def infer_ac_model(self): | |||
| return self.pvwatts_inverter | |||
| else: | |||
| raise ValueError('could not infer AC model from ' | |||
| 'system.inverter_parameters') | |||
| 'system.inverter_parameters. Check parameters or ' | |||
| 'explicity set model with ac_model kwarg.') | |||
There was a problem hiding this comment.
explicitly set the model with the ac_model kwarg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.