Skip to content

refactor: lots of typing updates, add pyright tests on CI #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

tlambert03
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 79.50820% with 25 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (758d519) to head (f12b213).

Files with missing lines Patch % Lines
src/ndv/views/_wx/range_slider.py 73.68% 5 Missing ⚠️
src/ndv/views/_pygfx/_array_canvas.py 82.60% 4 Missing ⚠️
src/ndv/views/_wx/_array_view.py 80.95% 4 Missing ⚠️
src/ndv/views/bases/_app.py 42.85% 4 Missing ⚠️
src/ndv/models/_lut_model.py 0.00% 2 Missing ⚠️
src/ndv/views/_vispy/_array_canvas.py 85.71% 2 Missing ⚠️
src/ndv/views/_vispy/_histogram.py 83.33% 2 Missing ⚠️
src/ndv/views/_pygfx/_histogram.py 0.00% 1 Missing ⚠️
src/ndv/views/_qt/_array_view.py 91.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (79.50%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
+ Coverage   85.23%   85.39%   +0.16%     
==========================================
  Files          46       46              
  Lines        4963     4979      +16     
==========================================
+ Hits         4230     4252      +22     
+ Misses        733      727       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant