Make qimage_to_array() work on big endian #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the returned ndarray is ordered the same as on little endian systems. Solves pyapp-kit#287
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 87.14% 87.01% -0.13%
==========================================
Files 49 49
Lines 3772 3774 +2
==========================================
- Hits 3287 3284 -3
- Misses 485 490 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Czaki
reviewed
Apr 6, 2025
Czaki
reviewed
Apr 6, 2025
Czaki
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the returned ndarray is ordered the same as on little
endian systems.
Solves #287