Open
Conversation
Author
|
PR for #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Return the nonce parameter from verify method (None is returned if it is not in the request).
Why
Because this allows the verifier caller to:
Alternative
I could also move the nonce reuse logic into the verifier and provide an enforce_has_nonce argument to the verify method but I decided against it because it would force the verifier to track long-running state (like the set of nonces used) or it would require the caller to give a handle to a function to check that a nonce has been used, both of which would increase the scope of the current API. Let me know if you prefer one of these options so I can rework the patch accordingly.