Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
8462010
Finished changes to base lithium ion model and SEI submodel
DrSOKane Feb 18, 2025
a57f516
Removed total SEI as it is now the same as SEI
DrSOKane Feb 21, 2025
3a18d62
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Feb 21, 2025
be55ba0
Changed 'Initial SEI thickness [m]' to 'Initial SEI concentration [mo…
DrSOKane Feb 21, 2025
5d7a89c
minor correction to Ai2020.py
DrSOKane Feb 21, 2025
3dc8c53
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Feb 21, 2025
1acde17
style: pre-commit fixes
pre-commit-ci[bot] Feb 21, 2025
8aad2ef
style fix
DrSOKane Feb 21, 2025
fd229e0
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Feb 21, 2025
bbe7eaf
fixed typo in base_sei.py
DrSOKane Feb 21, 2025
031cba4
Removed references to the old 'total SEI' variables
DrSOKane Feb 21, 2025
fae6a70
style: pre-commit fixes
pre-commit-ci[bot] Feb 21, 2025
819a0c4
Replaced L_sei_0 in dead lithium decay rate functions with a scalar
DrSOKane Feb 21, 2025
b003988
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Feb 21, 2025
95b3b1a
style: pre-commit fixes
pre-commit-ci[bot] Feb 21, 2025
2b5fdf0
Removed reference to initial SEI thickness in reaction_driven_porosit…
DrSOKane Feb 21, 2025
d9455f3
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Feb 21, 2025
ed3feae
Fixed merge conflict in cycling_ageing.py
DrSOKane Feb 27, 2025
1fc07d3
Added value and citation for initial SEI concentration on Li metal
DrSOKane Feb 27, 2025
c0f8ba8
Removed a reference to total SEI that crept back in
DrSOKane Feb 27, 2025
c4858f7
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Feb 28, 2025
cf652a0
fixed some citations
DrSOKane Feb 28, 2025
c28351e
Changed solver in half cell notebook to IDAKLU
DrSOKane Feb 28, 2025
b5c63ad
Removed reference to Liu and Lu, because Safari et al. is sufficient
DrSOKane Feb 28, 2025
7962766
Merge branch 'develop' into SEI-variable-change
rtimms Mar 4, 2025
4e99f94
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Mar 17, 2025
8bb9951
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Mar 17, 2025
880c355
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Mar 28, 2025
b618798
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Mar 31, 2025
b653bf1
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Mar 31, 2025
43f490a
Merge branch 'develop' into SEI-variable-change
DrSOKane Jul 8, 2025
019e430
style: pre-commit fixes
pre-commit-ci[bot] Jul 8, 2025
fbb65cc
Merge branch 'develop' into SEI-variable-change
kratman Jul 9, 2025
94ba0f2
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Jul 25, 2025
fd27c7c
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Jul 25, 2025
7930b68
changelog
DrSOKane Jul 25, 2025
73eb376
Merge branch 'develop' into SEI-variable-change
rtimms Sep 10, 2025
c6db6c9
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Sep 28, 2025
50fb6a0
Added more comments to sei_growth.py
DrSOKane Sep 28, 2025
ef0a19d
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Sep 28, 2025
c3a8aa0
Merge branch 'develop' into SEI-variable-change
DrSOKane Oct 1, 2025
d224d31
Changed initial condition back to thickness
DrSOKane Oct 17, 2025
fbc422f
Merge branch 'develop' of https://github.com/pybamm-team/PyBaMM into …
DrSOKane Oct 17, 2025
e3ebf5d
changelog
DrSOKane Oct 17, 2025
bbc740c
Fixed initial conditions for base_sei and constant_sei
DrSOKane Oct 17, 2025
c9fff0d
Added formation and storage loss example
DrSOKane Oct 19, 2025
573ac67
style: pre-commit fixes
pre-commit-ci[bot] Oct 19, 2025
6ca03d6
Added new notebook to TOC tree
DrSOKane Oct 19, 2025
06d8f56
Merge branch 'SEI-variable-change' of https://github.com/DrSOKane/PyB…
DrSOKane Oct 19, 2025
69475fa
Lychee doesn't like ACS links for some reason?
DrSOKane Oct 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
- Fixes a bug where sensitivities for 1D+ variables calculated using the `output_variables` options were incorrect ([#5118](https://github.com/pybamm-team/PyBaMM/pull/5118))
- Fix Bruggeman coefficient computation from BPX porosity and transport efficiency instead of hard-coding, remove redundant values, and add a unit test for verification. ([#5196](https://github.com/pybamm-team/PyBaMM/pull/5196))

## Breaking changes

- Changed fundamental variable for all SEI models from thickness to concentration ([#4869](https://github.com/pybamm-team/PyBaMM/pull/4869))

# [v25.8.0](https://github.com/pybamm-team/PyBaMM/tree/v25.8.0) - 2025-08-04


Expand Down
1 change: 1 addition & 0 deletions docs/source/examples/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ The notebooks are organised into subfolders, and can be viewed in the galleries
notebooks/simulations_and_experiments/callbacks.ipynb
notebooks/simulations_and_experiments/custom-experiments.ipynb
notebooks/simulations_and_experiments/experiments-start-time.ipynb
notebooks/simulations_and_experiments/formation-storage-loss.ipynb
notebooks/simulations_and_experiments/rpt-experiment.ipynb
notebooks/simulations_and_experiments/simulating-long-experiments.ipynb
notebooks/simulations_and_experiments/simulation-class.ipynb
Expand Down
4 changes: 2 additions & 2 deletions docs/source/examples/notebooks/models/SEI-on-cracks.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"id": "c46a0904",
"metadata": {},
"source": [
"Define two models. In model1, the only degradation mechanism is solvent-diffusion limited SEI growth. model2 includes the same SEI growth mechanism but also includes particle cracking and SEI growth on the cracks. The SEI model is run twice: once on the initial surface and once on the cracks. The equations for SEI on cracks are reported by O'Kane et al. [9] To ensure a fair experiment, particle swelling is enabled in both models."
"Define two models. In model1, the only degradation mechanism is solvent-diffusion limited SEI growth. model2 includes the same SEI growth mechanism but also includes particle cracking and SEI growth on the cracks. The SEI model is run twice: once on the initial surface and once on the cracks. The equations for SEI on cracks are reported by O'Kane et al. [10] To ensure a fair experiment, particle swelling is enabled in both models."
]
},
{
Expand Down Expand Up @@ -256,7 +256,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.3"
"version": "3.10.12"
},
"vscode": {
"interpreter": {
Expand Down
68 changes: 32 additions & 36 deletions docs/source/examples/notebooks/models/half-cell.ipynb

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@
},
{
"cell_type": "code",
"execution_count": 4,
"execution_count": null,
"metadata": {},
"outputs": [
{
Expand Down Expand Up @@ -262,8 +262,8 @@
" \"Current [A]\",\n",
" \"Sum of x-averaged negative electrode volumetric interfacial current densities [A.m-3]\",\n",
" \"X-averaged negative electrode active material volume fraction\",\n",
" \"Negative total SEI thickness [m]\",\n",
" \"X-averaged negative total SEI thickness [m]\",\n",
" \"Negative SEI thickness [m]\",\n",
" \"X-averaged negative SEI thickness [m]\",\n",
" ]\n",
")"
]
Expand Down Expand Up @@ -545,7 +545,7 @@
},
{
"cell_type": "code",
"execution_count": 9,
"execution_count": null,
"metadata": {},
"outputs": [
{
Expand Down Expand Up @@ -635,8 +635,8 @@
" \"Sum of x-averaged negative electrode volumetric interfacial current densities [A.m-3]\",\n",
" \"X-averaged negative electrode primary active material volume fraction\",\n",
" \"X-averaged negative electrode secondary active material volume fraction\",\n",
" \"Negative total primary SEI thickness [m]\",\n",
" \"Negative total secondary SEI thickness [m]\",\n",
" \"Negative primary SEI thickness [m]\",\n",
" \"Negative secondary SEI thickness [m]\",\n",
" ]\n",
")"
]
Expand Down

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions examples/scripts/calendar_ageing.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@
"Negative particle surface concentration",
"X-averaged negative particle surface concentration",
"Electrolyte concentration [mol.m-3]",
"Negative total SEI thickness [m]",
"X-averaged negative total SEI thickness [m]",
"Negative SEI concentration [mol.m-3]",
"X-averaged negative SEI concentration [mol.m-3]",
"X-averaged negative SEI thickness [m]",
"Sum of x-averaged negative electrode volumetric "
"interfacial current densities [A.m-3]",
"Loss of lithium inventory [%]",
Expand Down
2 changes: 1 addition & 1 deletion examples/scripts/cycling_ageing.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"X-averaged negative electrode SEI interfacial current density [A.m-2]",
"X-averaged negative electrode lithium plating interfacial current density "
"[A.m-2]",
"X-averaged negative total SEI thickness [m]",
"X-averaged negative SEI concentration [mol.m-3]",
"X-averaged negative dead lithium concentration [mol.m-3]",
[
"Total lithium lost [mol]",
Expand Down
36 changes: 36 additions & 0 deletions setup.log
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
2024-07-02 14:23:09,724 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-07-02 14:23:09,724 - PyBaMM setup - INFO - Not running on windows
2024-07-02 14:23:09,898 - PyBaMM setup - INFO - Found CMake.
2024-07-02 14:23:09,898 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-07-02 14:23:10,406 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-07-02 14:23:10,406 - PyBaMM setup - INFO - Not running on windows
2024-07-02 14:23:10,558 - PyBaMM setup - INFO - Found CMake.
2024-07-02 14:23:10,558 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-07-02 14:23:56,390 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-07-02 14:23:56,391 - PyBaMM setup - INFO - Not running on windows
2024-07-02 14:23:56,572 - PyBaMM setup - INFO - Found CMake.
2024-07-02 14:23:56,572 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-08-27 10:21:30,377 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-08-27 10:21:30,378 - PyBaMM setup - INFO - Not running on windows
2024-08-27 10:21:30,536 - PyBaMM setup - INFO - Found CMake.
2024-08-27 10:21:30,536 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-08-27 10:21:31,060 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-08-27 10:21:31,060 - PyBaMM setup - INFO - Not running on windows
2024-08-27 10:21:31,215 - PyBaMM setup - INFO - Found CMake.
2024-08-27 10:21:31,216 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-08-27 10:21:38,450 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-08-27 10:21:38,450 - PyBaMM setup - INFO - Not running on windows
2024-08-27 10:21:38,604 - PyBaMM setup - INFO - Found CMake.
2024-08-27 10:21:38,605 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-11-25 14:26:23,667 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-11-25 14:26:23,668 - PyBaMM setup - INFO - Not running on windows
2024-11-25 14:26:23,814 - PyBaMM setup - INFO - Found CMake.
2024-11-25 14:26:23,814 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-11-25 14:26:24,395 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-11-25 14:26:24,396 - PyBaMM setup - INFO - Not running on windows
2024-11-25 14:26:24,541 - PyBaMM setup - INFO - Found CMake.
2024-11-25 14:26:24,541 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2024-11-25 14:26:27,482 - PyBaMM setup - INFO - Starting PyBaMM setup
2024-11-25 14:26:27,483 - PyBaMM setup - INFO - Not running on windows
2024-11-25 14:26:27,648 - PyBaMM setup - INFO - Found CMake.
2024-11-25 14:26:27,648 - PyBaMM setup - INFO - Could not find PyBind11 directory (/home/drsokane/PyBaMM/pybind11). Skipping compilation of KLU module.
2 changes: 1 addition & 1 deletion src/pybamm/input/parameters/lithium_ion/Ai2020.py
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ def get_parameter_values():
"SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
"Lithium interstitial reference concentration [mol.m-3]": 15.0,
"Initial SEI thickness [m]": 5e-09,
"Initial SEI on cracks thickness [m]": 5e-13, # avoid division by zero
"Initial SEI on cracks thickness [m]": 5e-13, # practically zero
"EC initial concentration in electrolyte [mol.m-3]": 4541.0,
"EC diffusivity [m2.s-1]": 2e-18,
"SEI kinetic rate constant [m.s-1]": 1e-12,
Expand Down
2 changes: 1 addition & 1 deletion src/pybamm/input/parameters/lithium_ion/Ecker2015.py
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def SEI_limited_dead_lithium_OKane2022(L_sei):
Parameters
----------
L_sei : :class:`pybamm.Symbol`
Total SEI thickness [m]
SEI thickness [m]
Returns
-------
:class:`pybamm.Symbol`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def SEI_limited_dead_lithium_OKane2022(L_sei):
Parameters
----------
L_sei : :class:`pybamm.Symbol`
Total SEI thickness [m]
SEI thickness [m]
Returns
-------
:class:`pybamm.Symbol`
Expand Down
6 changes: 3 additions & 3 deletions src/pybamm/input/parameters/lithium_ion/OKane2022.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def SEI_limited_dead_lithium_OKane2022(L_sei):
Parameters
----------
L_sei : :class:`pybamm.Symbol`
Total SEI thickness [m]
SEI thickness [m]
Returns
-------
:class:`pybamm.Symbol`
Expand Down Expand Up @@ -522,7 +522,7 @@ def get_parameter_values():
"Dead lithium decay constant [s-1]": 1e-06,
"Dead lithium decay rate [s-1]": SEI_limited_dead_lithium_OKane2022,
# sei
"Ratio of lithium moles to SEI moles": 1.0,
"Ratio of lithium moles to SEI moles": 1.0, # not physical but true to paper
"SEI partial molar volume [m3.mol-1]": 9.585e-05,
"SEI reaction exchange current density [A.m-2]": 1.5e-07,
"SEI resistivity [Ohm.m]": 200000.0,
Expand All @@ -533,7 +533,7 @@ def get_parameter_values():
"SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
"Lithium interstitial reference concentration [mol.m-3]": 15.0,
"Initial SEI thickness [m]": 5e-09,
"Initial SEI on cracks thickness [m]": 5e-13, # avoid division by zero
"Initial SEI on cracks thickness [m]": 5e-13, # practically zero
"EC initial concentration in electrolyte [mol.m-3]": 4541.0,
"EC diffusivity [m2.s-1]": 2e-18,
"SEI kinetic rate constant [m.s-1]": 1e-12,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def SEI_limited_dead_lithium_OKane2022(L_sei):
Parameters
----------
L_sei : :class:`pybamm.Symbol`
Total SEI thickness [m]
SEI thickness [m]
Returns
-------
:class:`pybamm.Symbol`
Expand Down Expand Up @@ -406,7 +406,7 @@ def get_parameter_values():
"Dead lithium decay constant [s-1]": 1e-06,
"Dead lithium decay rate [s-1]": SEI_limited_dead_lithium_OKane2022,
# sei
"Ratio of lithium moles to SEI moles": 1.0,
"Ratio of lithium moles to SEI moles": 1.0, # not physical but true to paper
"SEI partial molar volume [m3.mol-1]": 9.585e-05,
"SEI reaction exchange current density [A.m-2]": 1.5e-07,
"SEI resistivity [Ohm.m]": 200000.0,
Expand All @@ -416,8 +416,8 @@ def get_parameter_values():
"SEI electron conductivity [S.m-1]": 8.95e-14,
"SEI lithium interstitial diffusivity [m2.s-1]": 1e-20,
"Lithium interstitial reference concentration [mol.m-3]": 15.0,
"Initial SEI thickness [m]": 5e-9,
"Initial SEI on cracks thickness [m]": 5e-13, # avoid division by zero
"Initial SEI thickness [m]": 5e-09,
"Initial SEI on cracks thickness [m]": 5e-13, # practically zero
"EC initial concentration in electrolyte [mol.m-3]": 4541.0,
"EC diffusivity [m2.s-1]": 2e-18,
"SEI kinetic rate constant [m.s-1]": 1e-12,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -282,12 +282,6 @@ def set_open_circuit_potential_submodel(self):

def set_sei_submodel(self):
for domain in ["negative", "positive"]:
if self.options.electrode_types[domain] == "planar":
reaction_loc = "interface"
elif self.options["x-average side reactions"] == "true":
reaction_loc = "x-average"
else:
reaction_loc = "full electrode"
phases = self.options.phases[domain]
for phase in phases:
sei_option = getattr(getattr(self.options, domain), phase)["SEI"]
Expand All @@ -301,12 +295,16 @@ def set_sei_submodel(self):
submodel = pybamm.sei.SEIGrowth(
self.param,
domain,
reaction_loc,
self.options,
phase,
cracks=False,
)
self.submodels[f"{domain} {phase} sei"] = submodel
self.submodels[f"{domain} {phase} sei thickness"] = (
pybamm.sei.SEIThickness(
self.param, domain, self.options, phase, cracks=False
)
)
if len(phases) > 1:
self.submodels[f"{domain} total sei"] = pybamm.sei.TotalSEI(
self.param, domain, self.options
Expand All @@ -330,19 +328,23 @@ def set_sei_on_cracks_submodel(self):
self.param, domain, self.options, phase, cracks=True
)
else:
if self.options["x-average side reactions"] == "true":
reaction_loc = "x-average"
else:
reaction_loc = "full electrode"
submodel = pybamm.sei.SEIGrowth(
self.param,
domain,
reaction_loc,
self.options,
phase,
cracks=True,
)
self.submodels[f"{domain} {phase} sei on cracks"] = submodel
self.submodels[f"{domain} {phase} sei on cracks thickness"] = (
pybamm.sei.SEIThickness(
self.param,
domain,
self.options,
phase,
cracks=True,
)
)
if len(phases) > 1:
self.submodels[f"{domain} total sei on cracks"] = (
pybamm.sei.TotalSEI(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,19 +129,15 @@ def get_coupled_variables(self, variables):
# Add SEI resistance
if self.options.electrode_types[domain] == "planar":
R_sei = self.phase_param.R_sei
L_sei = variables[
f"{Domain} total {phase_name}SEI thickness [m]"
] # on interface
L_sei = variables[f"{Domain} {phase_name}SEI thickness [m]"] # on interface
eta_sei = -j_tot_av * L_sei * R_sei
elif self.options["SEI film resistance"] == "average":
R_sei = self.phase_param.R_sei
L_sei_av = variables[
f"X-averaged {domain} total {phase_name}SEI thickness [m]"
]
L_sei_av = variables[f"X-averaged {domain} {phase_name}SEI thickness [m]"]
eta_sei = -j_tot_av * L_sei_av * R_sei
elif self.options["SEI film resistance"] == "distributed":
R_sei = self.phase_param.R_sei
L_sei = variables[f"{Domain} total {phase_name}SEI thickness [m]"]
L_sei = variables[f"{Domain} {phase_name}SEI thickness [m]"]
j_tot = variables[
f"Total {domain} electrode {phase_name}"
"interfacial current density variable [A.m-2]"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ def get_coupled_variables(self, variables):
if self.options["SEI film resistance"] != "none":
R_sei = self.phase_param.R_sei
if self.options.electrode_types[domain] == "planar":
L_sei = variables[f"{Domain} total SEI thickness [m]"]
L_sei = variables[f"{Domain} SEI thickness [m]"]
else:
L_sei = variables[f"X-averaged {domain} total SEI thickness [m]"]
L_sei = variables[f"X-averaged {domain} SEI thickness [m]"]
eta_sei = -j_tot * L_sei * R_sei
# Without SEI resistance
else:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,7 @@ def set_rhs(self, variables):
f"X-averaged {domain} electrode {phase_name}lithium plating volumetric "
"interfacial current density [A.m-3]"
]
L_sei = variables[
f"X-averaged {domain} total {phase_name}SEI thickness [m]"
]
L_sei = variables[f"X-averaged {domain} {phase_name}SEI thickness [m]"]
else:
c_plated_Li = variables[
f"{Domain} {phase_name}lithium plating concentration [mol.m-3]"
Expand All @@ -133,7 +131,7 @@ def set_rhs(self, variables):
f"{Domain} electrode {phase_name}lithium plating volumetric "
"interfacial current density [A.m-3]"
]
L_sei = variables[f"{Domain} total {phase_name}SEI thickness [m]"]
L_sei = variables[f"{Domain} {phase_name}SEI thickness [m]"]

lithium_plating_option = getattr(getattr(self.options, domain), self.phase)[
"lithium plating"
Expand Down
5 changes: 4 additions & 1 deletion src/pybamm/models/submodels/interface/sei/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
from .base_sei import BaseModel
from .total_sei import TotalSEI
from .sei_thickness import SEIThickness
from .no_sei import NoSEI
from .constant_sei import ConstantSEI
from .sei_growth import SEIGrowth

__all__ = ['base_sei', 'constant_sei', 'no_sei', 'sei_growth', 'total_sei']
__all__ = [
'base_sei', 'constant_sei', 'no_sei', 'sei_growth', 'sei_thickness', 'total_sei'
]
Loading