perf: precalculate state mapper for mapping between experimental steps#5380
Merged
MarcBerliner merged 15 commits intomainfrom Feb 25, 2026
Merged
perf: precalculate state mapper for mapping between experimental steps#5380MarcBerliner merged 15 commits intomainfrom
MarcBerliner merged 15 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
- Coverage 98.30% 98.24% -0.06%
==========================================
Files 328 328
Lines 28952 29052 +100
==========================================
+ Hits 28460 28542 +82
- Misses 492 510 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcBerliner
requested changes
Feb 24, 2026
Member
MarcBerliner
left a comment
There was a problem hiding this comment.
Thanks Martin, this is a nice performance boost! Just some minor comments
Co-authored-by: Marc Berliner <34451391+MarcBerliner@users.noreply.github.com>
Member
MarcBerliner
left a comment
There was a problem hiding this comment.
Thanks @martinjrobins, looks good to me other than the doctest failure
MarcBerliner
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Pre-calculate state mapper during simulation setup instead of on-demand at each step. performance gains mainly for smaller models (SPM)
Changes
base_model.pybuild_initial_state_mapper()methodsimulation.pybase_solver.pytest_simulation_with_experiment.pyBenchmark Results (10 repeats)
Note: Positive values indicate speedup (mapper is faster). 10 repeats per case.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests