Skip to content

Conversation

ankitpokhrel08
Copy link

As requested, the twitter link was replaced with the linkedIn and I have added some content as well.
#226

Before

Screenshot 2025-10-03 at 1 45 38 AM

After

Screenshot 2025-10-03 at 1 45 21 AM

I also added linkedin.svg logo and added it to Footer as:

Before

Screenshot 2025-10-03 at 1 47 37 AM

After

Screenshot 2025-10-03 at 1 48 03 AM

Responsive across devices

Screenshot 2025-10-03 at 1 48 35 AM

Re: LinkedIn oEmbed functionality

No, LinkedIn doesn't provide oEmbed functionality like Twitter does.

Copy link

netlify bot commented Oct 2, 2025

Deploy Preview for pybamm-developer-preview failed.

Name Link
🔨 Latest commit 02d0f1d
🔍 Latest deploy log https://app.netlify.com/projects/pybamm-developer-preview/deploys/68dedc1abcea170008076c1b

@ankitpokhrel08
Copy link
Author

The LinkedIn icon was added locally to the theme. Deployment failed because the icon commit isn't in the upstream theme repo https://github.com/scientific-python/scientific-python-hugo-theme yet.

Maintainers may need to add the LinkedIn icon to the theme first.

@agriyakhetarpal
Copy link
Member

Hi @ankitpokhrel08, thanks for experimenting with this! Could you explore adding the LinkedIn SVG to either the static/assets/ folder or the assets/icons/ folder or similar (commenting from my phone, not sure of the right location) and see if that works? Otherwise, could you please add the logo upstream, and we can update the theme submodule when done? This is how they integrated Bluesky: scientific-python/scientific-python-hugo-theme#673

@ankitpokhrel08
Copy link
Author

Created a pull request in the original submodule for the logo. @agriyakhetarpal

scientific-python/scientific-python-hugo-theme#677

@agriyakhetarpal
Copy link
Member

Thanks for opening the PR upstream! Let's hope someone can get to it sometime soon. In the meantime, I figured out a way to make embeds work. How about we embed a specific post from the PyBaMM LinkedIn page?

I think we can work with the following:

<iframe src="https://www.linkedin.com/embed/feed/update/urn:li:share:7290208134936059904?collapsed=1" height="719" width="504" frameborder="0" allowfullscreen="" title="Embedded post"></iframe>

which I got from this post: https://www.linkedin.com/posts/pybamm_tutorial-1-how-to-run-a-model-activity-7290208135712014336-5Jdy. Since it's about the first tutorial notebook, I think this is relevant enough to include.

(with the title, the width and height values, etc., adjusted, of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants