Skip to content

add with_console_options config, deprecate console_mode #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Mar 26, 2025

This begins the process of making the console options more like Python; we allow either Some(console_options) or None and configure these completely independently of send_to_logfire.

Copy link

hyperlint-ai bot commented Mar 26, 2025

PR Change Summary

Introduced with_console_options configuration and deprecated console_mode to enhance console options functionality.

  • Added with_console_options configuration for console options.
  • Deprecated console_mode in favor of independent console options.
  • Updated example code to reflect the new configuration.

Modified Files

  • README.md

How can I customize these reviews?

Check out the Hyperlint AI Reviewer docs for more information on how to customize the review.

If you just want to ignore it on this PR, you can add the hyperlint-ignore label to the PR. Future changes won't trigger a Hyperlint review.

Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add hyperlint-ignore to the PR to ignore the link check for this PR.

What is Hyperlint?

Hyperlint is an AI agent that helps you write, edit, and maintain your documentation.

Learn more about the Hyperlint AI reviewer and the checks that we can run on your documentation.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib.rs 68.42% 5 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@davidhewitt davidhewitt enabled auto-merge (squash) March 26, 2025 13:39
@davidhewitt davidhewitt merged commit cc29827 into main Mar 26, 2025
8 checks passed
@davidhewitt davidhewitt deleted the dh/console-options branch March 26, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants