Skip to content

support tracing metrics layer #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025
Merged

Conversation

davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Jul 10, 2025

Adds an advanced option to enable collecting metrics from tracing events using the tracing-opentelemetry::MetricsLayer pattern.

@davidhewitt
Copy link
Contributor Author

Will seek to get this merged and released Monday; main thing missing is to update the documentation to explain what's going on here. I would also like to make it this opt-in via an advanced option.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2025

Codecov Report

Attention: Patch coverage is 87.57764% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bridges/tracing.rs 86.47% 13 Missing and 25 partials ⚠️
src/lib.rs 88.88% 1 Missing ⚠️
src/test_utils.rs 96.42% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@davidhewitt davidhewitt marked this pull request as ready for review July 15, 2025 12:07
@davidhewitt davidhewitt merged commit c5fedd3 into main Jul 15, 2025
7 checks passed
@davidhewitt davidhewitt deleted the dh/support-tracing-metrics branch July 15, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants