Skip to content

Conversation

@adtyavrdhn
Copy link
Contributor

@adtyavrdhn adtyavrdhn commented Sep 17, 2025

Adds Response Body Capture for #1227

Introduces capture_response_body to Aiohttp Client Instrumentation

@codecov
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@adtyavrdhn adtyavrdhn marked this pull request as ready for review September 17, 2025 15:47
@alexmojaki
Copy link
Contributor

I don't like the idea of having capture_all when it doesn't capture the request body. It may mislead users, especially if they're familiar with capture_all for httpx, and there's less reason to have it when it's only replacing one flag anyway.

@adtyavrdhn
Copy link
Contributor Author

adtyavrdhn commented Sep 17, 2025

Yeah I was thinking the same thing, I'll roll it back and add it when I can add support for request body capture as well. Looks weird in the documentation as well.

Copy link
Contributor

@alexmojaki alexmojaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexmojaki alexmojaki enabled auto-merge (squash) September 18, 2025 16:14
@alexmojaki alexmojaki merged commit 5d37a10 into pydantic:main Sep 18, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants