Improve canonicalize_exception_traceback for RecursionError
#1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
4027982
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7986d4ae.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-canon-recursion.logfire-docs.pages.dev |
alexmojaki
commented
Oct 3, 2025
| # These can easily vary between runs and we don't want to pay attention to them, | ||
| # the real problem is the recursion itself. | ||
| parts.append('\n<recursion detected>\n') | ||
| break |
There was a problem hiding this comment.
Here's what happens without this:
There was a problem hiding this comment.
Pull Request Overview
This PR improves the canonicalize_exception_traceback function to better handle RecursionError exceptions by detecting recursive patterns and truncating the traceback output to avoid overwhelming detail from non-recursive frames at the end of the stack.
Key changes:
- Added recursion detection logic that triggers after 100 repeated frames for
RecursionErrorexceptions - Enhanced test coverage with comprehensive recursion scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| logfire/_internal/utils.py | Added recursion detection and early termination logic for RecursionError tracebacks |
| tests/test_canonicalize_exception.py | Added comprehensive test cases covering different recursion patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.