Skip to content

Conversation

@petyosi
Copy link
Contributor

@petyosi petyosi commented Oct 17, 2025

I noticed that the schema in the docs is missing quite a few fields. This is an up-to-date export.

@petyosi petyosi requested a review from Copilot October 17, 2025 07:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the records table schema to reflect the current database structure. The outdated schema was missing many fields and had inconsistencies in field definitions.

Key changes:

  • Added numerous missing fields including HTTP-related attributes, telemetry SDK information, and exception details
  • Updated field types and constraints (added NOT NULL constraints, changed some data types)
  • Added new fields like duration, project_id, day, and various HTTP and deployment-related columns

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2025

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51599eb
Status: ✅  Deploy successful!
Preview URL: https://1800f7cf.logfire-docs.pages.dev
Branch Preview URL: https://update-records-schema.logfire-docs.pages.dev

View logs

@Kludex
Copy link
Member

Kludex commented Oct 17, 2025

We should automate this.

@alexmojaki
Copy link
Contributor

👎 I prefer to link to https://logfire.pydantic.dev/docs/reference/sql/

@petyosi petyosi force-pushed the update-records-schema branch from 5e338ca to 72e93b4 Compare October 21, 2025 10:58
@petyosi
Copy link
Contributor Author

petyosi commented Oct 21, 2025

👎 I prefer to link to https://logfire.pydantic.dev/docs/reference/sql/

I changed the link in the platform to go directly to the SQL reference, removed the table and added a link to the reference. @alexmojaki let me know what you think.

@petyosi petyosi requested a review from alexmojaki October 21, 2025 10:59
@alexmojaki
Copy link
Contributor

I'll note that this whole section needs updating.

petyosi and others added 2 commits October 21, 2025 16:14
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
Co-authored-by: Alex Hall <alex.mojaki@gmail.com>
@alexmojaki alexmojaki changed the title Update records schema Docs: link to SQL reference Oct 21, 2025
@alexmojaki
Copy link
Contributor

Thanks

@alexmojaki alexmojaki merged commit c82a1c7 into main Oct 21, 2025
14 checks passed
@alexmojaki alexmojaki deleted the update-records-schema branch October 21, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants