Support OpenTelemetry 1.38, fix instrument_google_genai and instrument_langchain
#1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying logfire-docs with
|
| Latest commit: |
57749a1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f80a913.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-up983475.logfire-docs.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates OpenTelemetry dependencies from version 1.38.0 to 1.39.0 and adapts code to accommodate breaking API changes in the OTel SDK. The main changes involve migrating from the deprecated Event/EventLogger API to the newer LogRecord/Logger API for Google GenAI instrumentation.
Key Changes
- Updated OpenTelemetry SDK dependency upper bounds to 1.39.0
- Migrated Google GenAI instrumentation from deprecated Event API to LogRecord API
- Enhanced langchain message transformation to handle different tool call formats
- Added type ignore comments for compatibility with new API signatures
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated OpenTelemetry dependencies to support version 1.39.0 and added version constraint for google-genai instrumentation |
| logfire/_internal/integrations/google_genai.py | Migrated from deprecated Event/EventLogger API to LogRecord/Logger API |
| logfire/_internal/exporters/processor_wrapper.py | Enhanced langchain message transformation to handle additional tool call formats |
| logfire/_internal/logs.py | Added type ignore comment for emit method signature |
| tests/test_pydantic_plugin.py | Added type ignore comment for SQLModel field definition |
| tests/otel_integrations/test_langchain.py | Updated test to use create_agent instead of create_react_agent and adjusted expected span names |
| .github/workflows/daily_deps_test.yml | Added test configuration for OTel version 1.37 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alexmojaki
changed the title
instrument_google_genai and instrument_langchain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.