Skip to content

Commit 8d2e563

Browse files
TomNicholaspre-commit-ci[bot]dcherian
authored
Downgrade zarr requests performance expectations for zarr 3.0.9 (#10491)
* new blank whatsnew * change expectations * set apparently changed too * .to_zarr is also issuing more get requests... * to_zarr also issuing more set requests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * more problems * just print all the changes in CI * more issues * Remove print statements Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
1 parent cb3ad04 commit 8d2e563

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

xarray/tests/test_backends.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3539,8 +3539,8 @@ def test_append(self) -> None:
35393539
if has_zarr_v3:
35403540
# TODO: verify these
35413541
expected = {
3542-
"set": 5,
3543-
"get": 4,
3542+
"set": 16,
3543+
"get": 8, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
35443544
"list_dir": 2,
35453545
"list_prefix": 1,
35463546
}
@@ -3564,8 +3564,8 @@ def test_append(self) -> None:
35643564
# 6057128b: {'iter': 5, 'contains': 2, 'setitem': 5, 'getitem': 10, "listdir": 5, "list_prefix": 0}
35653565
if has_zarr_v3:
35663566
expected = {
3567-
"set": 4,
3568-
"get": 9, # TODO: fixme upstream (should be 8)
3567+
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
3568+
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
35693569
"list_dir": 2, # TODO: fixme upstream (should be 2)
35703570
"list_prefix": 0,
35713571
}
@@ -3587,8 +3587,8 @@ def test_append(self) -> None:
35873587

35883588
if has_zarr_v3:
35893589
expected = {
3590-
"set": 4,
3591-
"get": 9, # TODO: fixme upstream (should be 8)
3590+
"set": 11, # TODO: fixme upstream (should be 4), see https://github.com/zarr-developers/zarr-python/issues/3199
3591+
"get": 23, # TODO: fixme upstream (should be 8), see https://github.com/zarr-developers/zarr-python/issues/3199
35923592
"list_dir": 2, # TODO: fixme upstream (should be 2)
35933593
"list_prefix": 0,
35943594
}
@@ -3621,8 +3621,8 @@ def test_region_write(self) -> None:
36213621
with self.create_zarr_target() as store:
36223622
if has_zarr_v3:
36233623
expected = {
3624-
"set": 5,
3625-
"get": 2,
3624+
"set": 16,
3625+
"get": 8, # TODO: fixme upstream (should be 2), see https://github.com/zarr-developers/zarr-python/issues/3199
36263626
"list_dir": 2,
36273627
"list_prefix": 4,
36283628
}

0 commit comments

Comments
 (0)