propagate attrs on coords in Dataset.map
#10602
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst
This makes sure we propagate attrs in coords in
Dataset.map
ifkeep_attrs == True
. It uses the same semantics as for the data variables, which means thatkeep_attrs=True
will overwrite any changes to the attrs by the mapped function.This hides the use of the division operator in some of the weighted operations, which are solely affected by the global
keep_attrs
property.Alternative implementation options:
DataArray._copy_attrs_from
iterate over the coordinates.Dataset.map
, we could also make all weighted ops receive akeep_attrs
parameter