Skip to content

Commit 43104f8

Browse files
committed
Workflow no longer tries to upload nonexistent artifact and intentionally failing test no longer intentionally fails
1 parent cdf2baf commit 43104f8

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

.github/workflows/run-ubuntu-checks.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,6 @@ jobs:
128128
name: pygame-wheels-coverage-{ matrix.os }-{ matrix.python }
129129
path: ./out
130130

131-
- name: Upload ctest log
132-
if: ${{ steps.build-pygame-ce.conclusion == 'success' && !cancelled() }}
133-
uses: actions/upload-artifact@v4
134-
with:
135-
name: ctest_suite_log-{ matrix.os }-{ matrix.python }
136-
path: ./ctest.log
137-
138131
# Run cppcheck static analysis on src_c changes
139132
run-cppcheck:
140133
runs-on: ubuntu-24.04

ctest/base_ctest.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ static PyObject *test__pg_is_int_tuple_floats(PyObject *self, PyObject *_null) {
5252
PyObject *arg2 = Py_BuildValue("(ddd)", -1.1, -2.2, -3.3);
5353
PyObject *arg3 = Py_BuildValue("(ddd)", 1.0, -2.0, -3.1);
5454

55-
TEST_ASSERT_EQUAL(1, _pg_is_int_tuple(arg1));
55+
TEST_ASSERT_EQUAL(0, _pg_is_int_tuple(arg1));
5656
TEST_ASSERT_EQUAL(0, _pg_is_int_tuple(arg2));
5757
TEST_ASSERT_EQUAL(0, _pg_is_int_tuple(arg3));
5858

0 commit comments

Comments
 (0)