Refactor alphablit #3404
Open
Refactor alphablit #3404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MightyJosip
added
the
Code quality/robustness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current alphablit has way too many repetitive code. For example, in each blend blitter, around 90% of the code is the same. So I decided to move it into the macro, and by that, reduce the file by around 40% of the lines.
The good side of this commit is that if we do eventual change on the blitter code, we only need to do it in the one place, the code became more modular. However, macros probably make the code harder to read, so we need to decide will we proceed with this change