-
-
Notifications
You must be signed in to change notification settings - Fork 193
Add Renderer.logical_to_window and Renderer.window_to_logical from SDL2 #3519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DickerDackel
wants to merge
13
commits into
pygame-community:main
Choose a base branch
from
DickerDackel:logicalsize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cde0a36
Add logical_to_window and window_to_logical from SDL2
DickerDackel a8a5b82
Stubs added, return type of window_to_logical fixed
DickerDackel 1bc113b
Fix devcheck by running `dev.py format`
DickerDackel e8bc095
Fix MS build that as warnings -> errors
DickerDackel c8c7aa8
Try to fix stubs...
DickerDackel 624bce8
tuple instead of *args, SDL3 migration guide follow
DickerDackel 78f3050
Accept and return floats everywhere, sdl3 aliases removed
DickerDackel d359970
double, not float!
DickerDackel c80750e
Wording of error messages follows review suggestion
DickerDackel 048fde4
modified test according to review
DickerDackel 259f700
dev.py format
DickerDackel b9c6e37
logical_to_window and window_to_logical for _sdl2.video
DickerDackel d276fc5
versionadded added
DickerDackel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.