Skip to content

docs: logical_size might be (0, 0) #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2025

Conversation

DickerDackel
Copy link
Contributor

When Renderer.logical_size hasn't been changed before, it will contain (0, 0) and not the size of the window as one might expect.

This bit me, and I only by chance found a remark pointing that out in the SDL2 docs.

This adds a similar remark to the pygame-ce docs.

When Renderer.logical_size hasn't been changed before, it will contain
(0, 0) and not the size of the window as one might expect.

This bit me, and I only by chance found a remark pointing that out in
the SDL2 docs.

This adds a similar remark to the pygame-ce docs.
@DickerDackel DickerDackel requested a review from a team as a code owner June 30, 2025 17:55
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🥳

@ankith26 ankith26 added this to the 2.5.6 milestone Jul 1, 2025
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to specify it

@damusss damusss merged commit 1048811 into pygame-community:main Jul 12, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants