-
-
Notifications
You must be signed in to change notification settings - Fork 192
The Reviewing Process
For your pull request to be merged into the main branch of Pygame Community Edition, and thus make it into future releases, it must first pass the reviewing process. There are three main hurdles to pass:
-
Your Pull request must obtain the green tick from the Automated Continuous Integration testing. This usually take about 40minutes to do a full run, failures are noted with the red X of disappointment. You can click on failed testing runs to see if you can work out why the test failed.
-
You must obtain a minimum of two approving reviews from the team of officially designated pygame-ce contributors. More reviews is better but two is the minimum.
-
You must obtain at least one review of your minimum two from the smaller pool of experienced reviewers These reviewers have been around the metaphorical pygame-ce block and have seen many PRs come and go. If you also produce many PR reviews you could be among their number.
- You can't review your own pull request.