Skip to content

Debug crashing jobs on executor with Python 3.11 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

Debug crashing jobs on executor with Python 3.11 #1200

wants to merge 12 commits into from
+3 −3

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen
Copy link
Member Author 

======================================================================
FAIL: test_job_executor_cancel (job.test_genericJob.TestGenericJob.test_job_executor_cancel)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pyiron_base/pyiron_base/tests/job/test_genericJob.py", line 528, in test_job_executor_cancel
    self.assertTrue(j.status.aborted)
AssertionError: False is not true

----------------------------------------------------------------------

jan-janssen
jan-janssen commented Oct 4, 2023
View reviewed changes
tests/job/test_genericJob.py
self.assertEqual(j.project.db.get_job_status(j.job_id), "submitted")
sleep(1)
self.assertEqual(j.project.db.get_job_status(j.job_id), "aborted")
self.assertEqual(j.status, "aborted")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the status remains in submitted rather than being switched to aborted.

@pmrv pmrv mentioned this pull request Oct 4, 2023
Merged
@jan-janssen jan-janssen closed this Oct 5, 2023
@jan-janssen jan-janssen reopened this Oct 5, 2023
@jan-janssen
Copy link
Member Author

Other people report similar issues with futures not being marked as done even after cancelling:
python/cpython#109934

@jan-janssen jan-janssen closed this Oct 5, 2023
@jan-janssen jan-janssen deleted the debug_job_crash branch October 5, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jan-janssen