Skip to content

Debug crashing jobs on executor with Python 3.11 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Debug crashing jobs on executor with Python 3.11 #1200

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
afa3061
Update test_genericJob.py
jan-janssen Oct 4, 2023
d6678eb
Update test_genericJob.py
jan-janssen Oct 4, 2023
7b609f6
Update test_genericJob.py
jan-janssen Oct 4, 2023
d4bbe90
Update test_genericJob.py
jan-janssen Oct 4, 2023
1961992
Update test_genericJob.py
jan-janssen Oct 4, 2023
c325af6
Update test_genericJob.py
jan-janssen Oct 4, 2023
73ddb33
Update test_genericJob.py
jan-janssen Oct 4, 2023
361aafd
more debugging
jan-janssen Oct 5, 2023
2836660
enforce sleep until future is done
jan-janssen Oct 5, 2023
b69a224
enforce single worker
jan-janssen Oct 5, 2023
7f94f4a
increase sleep
jan-janssen Oct 5, 2023
44995b1
just set an empty future
jan-janssen Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/job/test_genericJob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,13 +518,13 @@ def test_job_executor_run(self):
def test_job_executor_cancel(self):
j = self.project.create_job(ReturnCodeJob, "job_with_executor_cancel")
j.input["accepted_codes"] = [1]
exe = ProcessPoolExecutor()
exe = ProcessPoolExecutor(max_workers=1)
j.server.executor = exe
self.assertTrue(j.server.run_mode.executor)
exe.submit(sleep, 1) # This part is a bit hacky, but it basically simulates other jobs on the same executor
j.run()
j.server.future = Future()
j.server.future.cancel()
j.refresh_job_status()
self.assertEqual(j.status, "aborted")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow the status remains in submitted rather than being switched to aborted.

self.assertTrue(j.status.aborted)

def test_job_executor_wait(self):
Expand Down