Skip to content

Commit b3f0e39

Browse files
authored
fix pip check for optional dependencies (#321)
* fix pip check for optional dependencies * remove nglview
1 parent cf1ba3a commit b3f0e39

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed

.ci_support/check.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import tomlkit
2+
3+
4+
if __name__ == "__main__":
5+
with open("pyproject.toml", "r") as f:
6+
data = tomlkit.load(f)
7+
8+
lst = []
9+
for sub_lst in data["project"]["optional-dependencies"].values():
10+
for el in sub_lst:
11+
lst.append(el)
12+
13+
data["project"]["dependencies"] += [el for el in set(lst) if not el.startswith("nglview")]
14+
15+
with open("pyproject.toml", "w") as f:
16+
f.writelines(tomlkit.dumps(data))

.github/workflows/pipeline.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,9 @@ jobs:
8080
- name: Pip check
8181
shell: bash -l {0}
8282
run: |
83-
pip install versioneer[toml]==0.29
83+
pip install versioneer[toml]==0.29 tomlkit
84+
python .ci_support/check.py
85+
cat pyproject.toml
8486
pip install . --no-deps --no-build-isolation
8587
python -m pip check
8688

0 commit comments

Comments
 (0)