[Bug]: LHC best knowledge model creation

[yangelis]

Bug Description

The madx job file seems to not call the extracted MQTs files. Seen when creating model though the gui and when manually running the test_lhc_creation_best_knowledge test

[JoschD]

When you run from the GUI, do you already extract the MQTs?
Because it's clearly in the code:

omc3/omc3/model/model_creators/lhc_model_creator.py

Lines 475 to 477 in b680964

	mqts_file = accel.model_dir / self.EXTRACTED_MQTS_FILENAME
	if mqts_file.exists():
	madx_script += f"call, file = '{mqts_file}';\n"

In the test it's an empty file:

omc3/tests/unit/test_model_creator.py

Line 269 in b680964

(tmp_path / LhcBestKnowledgeCreator.EXTRACTED_MQTS_FILENAME).write_text("\n")

This should probably be replaced with an mqt_str as content which we can check that it was read, similar to the corrections_str below

[yangelis]

Line 477 is the one missing in the job files:

omc3/omc3/model/model_creators/lhc_model_creator.py

Lines 475 to 477 in b680964

	mqts_file = accel.model_dir / self.EXTRACTED_MQTS_FILENAME
	if mqts_file.exists():
	madx_script += f"call, file = '{mqts_file}';\n"

[JoschD]

yeah, just saw it. It looks like the model-directory is not set correctly.
My test with the string suggested above should really be added.

[JoschD]

I just checked the betabeat-nfs ( find 2025* -type f -name '*_best_knowledge.madx') directory and it seems this has not been an issue last year, but every best-knowledge model created this year was missing the MQTs.

[yangelis]

So the problem comes from

omc3/omc3/model/model_creators/abstract_model_creator.py

Lines 95 to 103 in b680964

	def full_run(self):
	""" Does the full run: preparation, running madx, post_run. """
	# Prepare model-dir output directory
	self.prepare_run()
	# get madx-script with relative output-paths
	# (model_dir is base-path in get_madx_script)
	self.accel.model_dir = Path()
	madx_script = self.get_madx_script()

since it is run before here

omc3/omc3/model/model_creators/lhc_model_creator.py

Lines 439 to 441 in b680964

	def prepare_run(self):
	accel: Lhc = self.accel
	super().prepare_run()