Skip to content

Conversation

@jacobtylerwalls
Copy link
Member

Type of Changes

Type
🐛 Bug fix

Description

Closes #10696

@jacobtylerwalls jacobtylerwalls added this to the 4.0.3 milestone Oct 25, 2025
@jacobtylerwalls jacobtylerwalls added False Positive 🦟 A message is emitted but nothing is wrong with the code C: invalid-name backport maintenance/4.0.x labels Oct 25, 2025
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.97%. Comparing base (25000a2) to head (21c7f55).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #10699   +/-   ##
=======================================
  Coverage   95.97%   95.97%           
=======================================
  Files         176      176           
  Lines       19529    19537    +8     
=======================================
+ Hits        18742    18750    +8     
  Misses        787      787           
Files with missing lines Coverage Δ
pylint/checkers/base/name_checker/checker.py 98.76% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on sentry:
The following messages are no longer emitted:

  1. invalid-name:
    Variable name "RpcImportResult" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/801bd3c25754f2120ae8603a533f2a4107a9709e/src/sentry/backup/services/import_export/model.py#L209
  2. invalid-name:
    Variable name "RpcExportResult" doesn't conform to snake_case naming style
    https://github.com/getsentry/sentry/blob/801bd3c25754f2120ae8603a533f2a4107a9709e/src/sentry/backup/services/import_export/model.py#L281

This comment was generated for commit 21c7f55

@Pierre-Sassoulas Pierre-Sassoulas merged commit bb9df16 into pylint-dev:main Oct 26, 2025
50 checks passed
pylint-backport bot pushed a commit that referenced this pull request Oct 26, 2025
Pierre-Sassoulas pushed a commit that referenced this pull request Oct 26, 2025
…nnotated` (#10701)

Fix FP for `invalid-name` with `typing.Annotated` (#10699)

(cherry picked from commit bb9df16)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls deleted the jtw/invalid-name-annotated branch October 26, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport maintenance/4.0.x C: invalid-name False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Naming requirements for annotated types depend on Python version (pylint 4 regression)

2 participants