Skip to content

feat #7713: implement ICARRV/CARRV as SymbolicRVs #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asifzubair
Copy link
Contributor

@asifzubair asifzubair commented Jul 30, 2025

Description

We will implement ICARRV and CARRV as SymbolicRVs by subclassing SymbolicMVNormalUsedInternally. This will eliminate the need for rng_fn.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7879.org.readthedocs.build/en/7879/

Copy link

codecov bot commented Jul 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (58b49f2) to head (0fbccf4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7879   +/-   ##
=======================================
  Coverage   92.94%   92.95%           
=======================================
  Files         116      116           
  Lines       18845    18857   +12     
=======================================
+ Hits        17516    17528   +12     
  Misses       1329     1329           
Files with missing lines Coverage Δ
pymc/distributions/multivariate.py 93.98% <100.00%> (+0.07%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asifzubair
Copy link
Contributor Author

Hi @jessegrabowski , could you please give this a review when you have a moment ? Thank you 🙏

@asifzubair asifzubair changed the title feat req. #7713: implement ICARRV/CARRV as SymbolicRVs feat #7713: implement ICARRV/CARRV as SymbolicRVs Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rng_fn to CAR/ICAR
1 participant