Implement Transpose for XTensorVariables #1430
Merged
+226
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AllenDowney I cherry-picked your changes from #1427, I squashed all the transpose related changes into a single one, and split unrelated changes into other 2 commits.
I pushed a fourth commit with changes that I'm listing here, and I would appreciate if you could in turn review them:
missing_dims
out of theOp
since this is not really a parameter that affects how theOp
behaves at runtime, and is therefore useless. I put the behavior in the helper that calls theTranspose
Op
instead. TheOp
will expect dims to be correctly specified and raise if not.expand_ellipsis
into themake_node
since that's the only place it's used and it's not insanely complex.x.T