Skip to content

Conversation

jonathanherbstgrapple
Copy link

This is how I was able to fix the issue I created #1754. Not sure if there are larger issues at play here.

@ithinuel ithinuel changed the base branch from main to develop February 19, 2025 17:58
@ithinuel
Copy link
Member

Hi, thank you for the contribution.

I see that the rx_task also sets _swo_thread_did_exit to true. I’m not sure if that’s the intended behaviour of if those two should be using a different *_thread_did_exit.

crypto-lars added a commit to crypto-lars/pyOCD that referenced this pull request Oct 10, 2025
SWO thread exit was set in RX thread. Fixed now
by setting RX thread exit flag instead.

Closes pyocd#1755.
@crypto-lars
Copy link

Hi, thank you for the contribution.

I see that the rx_task also sets _swo_thread_did_exit to true. I’m not sure if that’s the intended behaviour of if those two should be using a different *_thread_did_exit.

I think this was not intended when this code was written and my pull request fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants