Skip to content

Commit ba4b7f1

Browse files
committed
Don't cache _version
1 parent 8f2e3d6 commit ba4b7f1

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

src/pip/_internal/metadata/pkg_resources.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ class Distribution(BaseDistribution):
1717
def __init__(self, dist):
1818
# type: (pkg_resources.Distribution) -> None
1919
self._dist = dist
20-
self._version = None
2120

2221
@classmethod
2322
def from_wheel(cls, path, name):
@@ -47,9 +46,7 @@ def canonical_name(self):
4746
@property
4847
def version(self):
4948
# type: () -> _BaseVersion
50-
if self._version is None:
51-
self._version = parse_version(self._dist.version)
52-
return self._version
49+
return parse_version(self._dist.version)
5350

5451
@property
5552
def installer(self):

src/pip/_internal/resolution/resolvelib/candidates.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ def __init__(
347347
self.dist = dist
348348
self._ireq = make_install_req_from_dist(dist, template)
349349
self._factory = factory
350-
self._version = None
351350

352351
# This is just logging some messages, so we can do it eagerly.
353352
# The returned dist would be exactly the same as self.dist because we
@@ -390,9 +389,7 @@ def name(self):
390389
@property
391390
def version(self):
392391
# type: () -> _BaseVersion
393-
if self._version is None:
394-
self._version = parse_version(self.dist.version)
395-
return self._version
392+
return parse_version(self.dist.version)
396393

397394
@property
398395
def is_editable(self):

0 commit comments

Comments
 (0)