Skip to content

Commit 7a1b80c

Browse files
committed
Mostly performance minded but does fix a bug upgrading packages with markers on CLI
1 parent 9a81fc0 commit 7a1b80c

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

pipenv/utils/resolver.py

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414
from pipenv.patched.pip._internal.commands.install import InstallCommand
1515
from pipenv.patched.pip._internal.exceptions import InstallationError
1616
from pipenv.patched.pip._internal.models.target_python import TargetPython
17+
from pipenv.patched.pip._internal.operations.build.build_tracker import (
18+
get_build_tracker,
19+
)
1720
from pipenv.patched.pip._internal.req.constructors import (
1821
install_req_from_parsed_requirement,
1922
)
@@ -76,18 +79,6 @@ def get_package_finder(
7679
)
7780

7881

79-
class BuildTracker:
80-
def __init__(self, root):
81-
self.root = root
82-
if not root:
83-
os.environ["PIP_BUILD_TRACKER"] = self.root
84-
85-
def cleanup(self):
86-
if self.root and "PIP_BUILD_TRACKER" in os.environ:
87-
del os.environ["PIP_BUILD_TRACKER"]
88-
# Add any necessary cleanup logic here
89-
90-
9182
class HashCacheMixin:
9283
"""Caches hashes of PyPI artifacts so we do not need to re-download them.
9384
@@ -431,8 +422,9 @@ def constraints(self):
431422
def resolve(self):
432423
from pipenv.patched.pip._internal.utils.temp_dir import TempDirectory
433424

434-
with global_tempdir_manager(), TempDirectory(globally_managed=True) as temp_dir:
435-
build_tracker = BuildTracker(temp_dir)
425+
with global_tempdir_manager(), get_build_tracker() as build_tracker, TempDirectory(
426+
globally_managed=True
427+
) as temp_dir:
436428
try:
437429
finder = self.finder()
438430
wheel_cache = WheelCache(self.pip_options.cache_dir)

0 commit comments

Comments
 (0)