Skip to content

Conversation

jjimenezshaw
Copy link
Contributor

@jjimenezshaw jjimenezshaw commented Mar 31, 2024

Adds new API to PROJ. database.query_geodetic_crs_from_datum

@jjimenezshaw jjimenezshaw force-pushed the query-geodetic-datum branch from dc10ebd to d15793e Compare March 31, 2024 10:24
@jjimenezshaw jjimenezshaw force-pushed the query-geodetic-datum branch from d15793e to 66ceda0 Compare April 4, 2024 21:09
@snowman2
Copy link
Member

I tried to re-produce the error and couldn't with main...snowman2:pyproj:docker .

To debug, I suggest modifying the CI tests to specifically run the test that fails and trying these configurations:

  • set PROJ_DEBUG environment variable to 3
  • add -vv flag to tests
  • Install gdb and run gdb -ex=r --args /venv/bin/python -B -m pytest test/test_database.py

@snowman2
Copy link
Member

Also, it may not hurt to rebase this PR against the latest version.

@jjimenezshaw jjimenezshaw force-pushed the query-geodetic-datum branch 2 times, most recently from e237f2e to 7b5cb5c Compare April 19, 2024 16:18
@jjimenezshaw
Copy link
Contributor Author

Also, it may not hurt to rebase this PR against the latest version.

I did rebase (after some problems), but the tests are not running. Is anything broken in the gh actions?

@snowman2 snowman2 closed this Apr 19, 2024
@snowman2 snowman2 reopened this Apr 19, 2024
@snowman2
Copy link
Member

I see this error:

The workflow is not valid. .github/workflows/tests.yaml (Line: 127, Col: 17): Unexpected value ''

@snowman2
Copy link
Member

snowman2 commented Jul 3, 2024

I was able to re-produce this with PROJ 9.3 (both docker & conda envs) and I did not encounter any errors with PROJ 9.4 on the docker image (#1390 (comment)):

test/test_database.py 
Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x000075ff9a5b3079 in proj_list_get_count () from /lib/x86_64-linux-gnu/libproj.so.25

If logic is added in the function to not allow running in PROJ 9.3, I would be okay with adding this in.

@snowman2 snowman2 force-pushed the main branch 6 times, most recently from 36d5482 to 7da1053 Compare August 8, 2024 13:24
@snowman2 snowman2 force-pushed the query-geodetic-datum branch 2 times, most recently from f86934f to 359918e Compare March 21, 2025 02:50
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.84%. Comparing base (b78a50d) to head (ad6e15c).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1390      +/-   ##
==========================================
- Coverage   96.55%   95.84%   -0.72%     
==========================================
  Files          20       20              
  Lines        1827     1827              
==========================================
- Hits         1764     1751      -13     
- Misses         63       76      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jjimenezshaw
Copy link
Contributor Author

If logic is added in the function to not allow running in PROJ 9.3, I would be okay with adding this in.

How can I do that? Is it done somewhere else in the code?

@snowman2
Copy link
Member

If logic is added in the function to not allow running in PROJ 9.3, I would be okay with adding this in.

How can I do that? Is it done somewhere else in the code?

This is no longer needed with #1481

@snowman2 snowman2 added this to the 3.8.0 milestone Sep 12, 2025
@jjimenezshaw
Copy link
Contributor Author

I had to change .pre-commit-config.yaml, otherwise I cannot do a commit.
I have an Ubuntu 24.04, and installed the conda environment as explained in https://github.com/jjimenezshaw/pyproj/blob/main/CONTRIBUTING.md

The error message is this:

An unexpected error has occurred: CalledProcessError: command: ('/home/jshaw/anaconda3/envs/pyproj-devel/bin/python', '-mvirtualenv', '/home/jshaw/.cache/pre-commit/repoc6h5_c3j/py_env-python3.11', '-p', 'python3.11')
return code: 1
stdout:
    RuntimeError: failed to find interpreter for Builtin discover of python_spec='python3.11'
stderr: (none)
Check the log at /home/jshaw/.cache/pre-commit/pre-commit.log

The installed python in the environment is

$ python3 --version
Python 3.13.7

@snowman2 snowman2 changed the title Add query_geodetic_crs_from_datum ENH: Add query_geodetic_crs_from_datum Sep 12, 2025
@snowman2 snowman2 merged commit 2d991e1 into pyproj4:main Sep 12, 2025
17 checks passed
@snowman2
Copy link
Member

Thanks @jjimenezshaw 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add proj_query_geodetic_crs_from_datum

2 participants