-
Notifications
You must be signed in to change notification settings - Fork 225
ENH: Add query_geodetic_crs_from_datum #1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dc10ebd
to
d15793e
Compare
d15793e
to
66ceda0
Compare
I tried to re-produce the error and couldn't with main...snowman2:pyproj:docker . To debug, I suggest modifying the CI tests to specifically run the test that fails and trying these configurations:
|
Also, it may not hurt to rebase this PR against the latest version. |
e237f2e
to
7b5cb5c
Compare
I did rebase (after some problems), but the tests are not running. Is anything broken in the gh actions? |
I see this error:
|
I was able to re-produce this with PROJ 9.3 (both docker & conda envs) and I did not encounter any errors with PROJ 9.4 on the docker image (#1390 (comment)):
If logic is added in the function to not allow running in PROJ 9.3, I would be okay with adding this in. |
36d5482
to
7da1053
Compare
f86934f
to
359918e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1390 +/- ##
==========================================
- Coverage 96.55% 95.84% -0.72%
==========================================
Files 20 20
Lines 1827 1827
==========================================
- Hits 1764 1751 -13
- Misses 63 76 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
359918e
to
05cabbe
Compare
How can I do that? Is it done somewhere else in the code? |
This is no longer needed with #1481 |
05cabbe
to
2ce2082
Compare
I had to change The error message is this:
The installed python in the environment is $ python3 --version
Python 3.13.7 |
2ce2082
to
ad6e15c
Compare
Thanks @jjimenezshaw 👍 |
Adds new API to PROJ.
database.query_geodetic_crs_from_datum
history.rst
for all changes andapi/*.rst
for new API