Skip to content

Conversation

@phaarnes
Copy link
Contributor

@snowman2
Copy link
Member

Mind adding an enumeration for these options similar to: https://github.com/pyproj4/pyproj/blob/b73f79f66b6cb7334fb800d237e7e650a9dde406/pyproj/enums.py#L75C7-L75C25 ?

@phaarnes
Copy link
Contributor Author

Mind adding an enumeration for these options similar to: https://github.com/pyproj4/pyproj/blob/b73f79f66b6cb7334fb800d237e7e650a9dde406/pyproj/enums.py#L75C7-L75C25 ?

Sure, will do

@phaarnes
Copy link
Contributor Author

@snowman2

  • I added the CRSExtentUse enum (in enums.py).
  • Updated the TransformerGroup type hints and docstring to accept it.
  • Adjusted the Cython binding to map enum values.
  • Added tests to handle both enum and string inputs.
  • Updated the history and "version added" notes accordingly.

@snowman2 snowman2 added this to the 3.8.0 milestone Oct 24, 2025
phaarnes and others added 5 commits October 27, 2025 10:15
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
Copy link
Contributor Author

@phaarnes phaarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Co-authored-by: Alan D. Snow <alansnow21@gmail.com>
@phaarnes
Copy link
Contributor Author

@snowman2
Your comments have been reviewed, and the suggestions have been implemented.

@snowman2
Copy link
Member

Thanks @phaarnes 👍. Looks like the code needs pre-commit to be run to address linting issues.

@phaarnes
Copy link
Contributor Author

@snowman2
Thanks! Ran pre-commit on updated branch. All hooks passed and lint issues seem to be resolved now.

@snowman2
Copy link
Member

Looks like there are linting issues still.

@phaarnes
Copy link
Contributor Author

@snowman2
Sorry for that! It should be fixed now. I made the necessary changes, ran the entire test loop locally, and all the tests did pass.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.85%. Comparing base (b78a50d) to head (7eb0cc1).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
- Coverage   96.55%   95.85%   -0.71%     
==========================================
  Files          20       20              
  Lines        1827     1832       +5     
==========================================
- Hits         1764     1756       -8     
- Misses         63       76      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snowman2 snowman2 merged commit bc88b98 into pyproj4:main Oct 29, 2025
18 checks passed
@snowman2
Copy link
Member

Thanks @phaarnes 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TransformerGroup should get an argument to ignore extents like "--crs-extent-use none" in the PROJ CLI

2 participants