Skip to content

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Jan 2, 2025

Description

Fixes the MacOS call for external RC testing.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran here: https://github.com/pysat/pysatMissions/actions/runs/12587268120/job/35082761515

Test Configuration

  • Operating system: GA
  • Version number: Python 3.12
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Fixed the apexpy mac installation command.
Attempt to fix the yaml syntax.
Removed `$` from the variable name.
@aburrell aburrell changed the base branch from main to develop January 2, 2025 18:55
@aburrell aburrell requested a review from jklenzing January 2, 2025 18:56
@aburrell aburrell added this to the 0.4.0 Release milestone Jan 2, 2025
Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added #126 to update the main.yml once the new apexpy is released.

@aburrell aburrell merged commit 2285a90 into develop Jan 2, 2025
28 of 31 checks passed
@aburrell aburrell deleted the tst_apexpy_rc branch January 2, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants