Skip to content
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

overjoyed otolaryngologists #4

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

ravenkls
Copy link

No description provided.

@jb3
Copy link
Member

jb3 commented Mar 7, 2019

I really like some of the ideas you've come up with to put a twist on the game. Though, not a huge amount of code and a lot of it was generated by Qt.

Pathlib could have been used to generate some of the paths where you instead used os to generate your paths.

@ravenkls
Copy link
Author

ravenkls commented Mar 7, 2019

Thanks for the feedback :) Although I think you understate the amount we produced, no 'code' was generated by Qt, unless you count a compiled resource file as code ¯_(ツ)_/¯

@jb3
Copy link
Member

jb3 commented Mar 7, 2019

Ah yeah the resource file did throw me off a bit (216,000 additions 👀). All other code was of high code quality 👍.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants