Update tests for DRF 3.16.0

New error messages are returned, and there appears to be an upstream bug
which presently requires us to specify all attributes in the update.

Author: jchristgit

pydis_site/apps/api/tests/test_bumped_threads.py

@@ -60,4 +60,7 @@ def test_returns_404_for_non_existing_data(self):
 
         response = self.client.get(url)
         self.assertEqual(response.status_code, 404)
-        self.assertEqual(response.json(), {"detail": "Not found."})
+        self.assertEqual(
+            response.json(),
+            {"detail": "No BumpedThread matches the given query."},
+        )

pydis_site/apps/api/tests/test_filters.py

@@ -210,8 +210,15 @@ def test_fetch_non_existing(self) -> None:
                 sequence.model.objects.all().delete()
 
                 response = self.client.get(f"{sequence.url()}/42")
+                if "filter-lists" in sequence.url():
+                    kind = "FilterList"
+                else:
+                    kind = "Filter"
                 self.assertEqual(response.status_code, 404)
-                self.assertDictEqual(response.json(), {'detail': 'Not found.'})
+                self.assertDictEqual(
+                    response.json(),
+                    {'detail': f"No {kind} matches the given query."},
+                )
 
     def test_creation(self) -> None:
         for name, sequence in get_test_sequences().items():

pydis_site/apps/api/tests/test_infractions.py

@@ -329,7 +329,7 @@ def test_partial_update(self):
 
     def test_partial_update_returns_400_for_frozen_field(self):
         url = reverse('api:bot:infraction-detail', args=(self.ban_hidden.id,))
-        data = {'user': 6}
+        data = {'user': 6, 'active': True}
 
         response = self.client.patch(url, data=data)
         self.assertEqual(response.status_code, 400)
@@ -559,7 +559,7 @@ def test_returns_400_for_second_active_infraction_of_the_same_type(self):
                     second_response.json(),
                     {
                         'non_field_errors': [
-                            'This user already has an active infraction of this type.'
+                            'The fields user, type must make a unique set.'
                         ]
                     }
                 )
@@ -824,7 +824,7 @@ def test_is_valid_if_active_infraction_with_same_fields_exists(self):
         self.create_infraction('ban', active=True)
         instance = self.create_infraction('ban', active=False)
 
-        data = {'reason': 'hello'}
+        data = {'reason': 'hello', 'active': True}
         serializer = InfractionSerializer(instance, data=data, partial=True)
 
         self.assertTrue(serializer.is_valid(), msg=serializer.errors)

pydis_site/apps/api/tests/test_nominations.py

@@ -379,7 +379,7 @@ def test_returns_404_on_get_unknown_nomination(self):
         response = self.client.get(url, data={})
         self.assertEqual(response.status_code, 404)
         self.assertEqual(response.json(), {
-            "detail": "Not found."
+            "detail": "No Nomination matches the given query."
         })
 
     def test_returns_404_on_patch_unknown_nomination(self):
@@ -391,7 +391,7 @@ def test_returns_404_on_patch_unknown_nomination(self):
         response = self.client.patch(url, data={})
         self.assertEqual(response.status_code, 404)
         self.assertEqual(response.json(), {
-            "detail": "Not found."
+            "detail": "No Nomination matches the given query."
         })
 
     def test_returns_405_on_list_put(self):

pydis_site/apps/api/tests/test_roles.py

@@ -208,4 +208,7 @@ def test_role_detail_404_all_methods(self):
         for method in ('get', 'put', 'patch', 'delete'):
             response = getattr(self.client, method)(url)
             self.assertEqual(response.status_code, 404)
-            self.assertJSONEqual(response.content, '{"detail": "Not found."}')
+            self.assertJSONEqual(
+                response.content,
+                '{"detail": "No Role matches the given query."}',
+            )

pydis_site/apps/api/tests/test_users.py

@@ -746,7 +746,7 @@ def verify_adding_existing_alt(self, add_on_source: bool) -> None:
         response = self.client.post(repeated_url, repeated_data)
         self.assertEqual(response.status_code, 400)
         self.assertEqual(response.json(), {
-            'source': ["This relationship has already been established"]
+            'non_field_errors': ["The fields source, target must make a unique set."]
         })
 
     def test_removing_existing_alt_source_from_target(self) -> None: