Handle Werkzeug 2.1.0 change to Response.autocorrect_location_header. #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python-restx#426 pallets/werkzeug#2352 changed the default value of Response.autocorrect_location_header from True to False in Werkzeug >= 2.1.0. tests/legacy/test_api_legacy.py::APITest::test_redirect depended upon Response.autocorrect_location_header being True. Change `test_redirect()` to explicitly set `Response.autocorrect_location_header` to `False`, for backwards compatibility, and change the expected result for the test from an absolute URL to the relative URL.
jayvdb
approved these changes
Oct 5, 2022
jayvdb
left a comment
jayvdb
left a comment
There was a problem hiding this comment.
This PR is used as a patch for https://build.opensuse.org/package/show/devel:languages:python:flask/python-flask-restx to allow building on rolling release Tumbleweed
ziirish
force-pushed
the
master
branch
2 times, most recently
from
0db7d06 to
4eaf373
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
pallets/werkzeug#2352 changed the default value of
Response.autocorrect_location_headerfromTruetoFalsein Werkzeug >= 2.1.0.tests/legacy/test_api_legacy.py::APITest::test_redirectdepended uponResponse.autocorrect_location_headerbeingTrue.Change
test_redirect()to explicitly setResponse.autocorrect_location_headertoFalse, for backwards compatibility, and change the expected result for the test from an absolute URL to the relative URL.