Skip to content

Issue 2077: Add sample playwright tests for folium #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hansthen
Copy link
Collaborator

@hansthen hansthen commented Apr 7, 2025

Gentlemen, I created a sample test using playwright and streamlit. This is not a full test suite, but more of a demonstration how we can use Playwright to test our example apps. I have used Playwright for a few other projects and I like how it works. It also comes with a nice codegen utility that can be used to jumpstart creating tests.

Let me know what you think of it.

@hansthen hansthen requested review from ocefpaf and Conengmo April 7, 2025 18:07
@hansthen hansthen marked this pull request as draft April 7, 2025 18:08
@hansthen hansthen force-pushed the playwright_tests branch 2 times, most recently from ce6081a to e531057 Compare April 14, 2025 18:20
@hansthen hansthen changed the title Add sample playwright tests for folium Issue 2077: Add sample playwright tests for folium Apr 19, 2025
@hansthen hansthen marked this pull request as ready for review April 19, 2025 05:23
@hansthen
Copy link
Collaborator Author

I am okay with the results for now. Please let me know what you think.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2025

I am okay with the results for now. Please let me know what you think.

I don't know what playwright is, and I'm not familiar enough with streamlit to review this PR. I'll leave this one for you and Frank. Sorry.

@hansthen
Copy link
Collaborator Author

I am okay with the results for now. Please let me know what you think.

I don't know what playwright is, and I'm not familiar enough with streamlit to review this PR. I'll leave this one for you and Frank. Sorry.

No problem. Playwright is a UI testing framework that is also used by the streamlit-folium people. It feels a lot like selenium, but with less baggage. I will make this PR a draft for now and focus first on getting the regressions to work.

@hansthen hansthen marked this pull request as draft April 22, 2025 16:18
@ocefpaf
Copy link
Member

ocefpaf commented Apr 22, 2025

It feels a lot like selenium, but with less baggage.

Cool! I'll watch this closely to learn something new.

@hansthen
Copy link
Collaborator Author

It feels a lot like selenium, but with less baggage.

Cool! I'll watch this closely to learn something new.

Thank you for your help! Half a dozen issues closed in a single day. I will prepare a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants