Gate PR's so they require CI checks to pass

[jeffwidman]

In #652, @StephenSorriaux very nicely fixed up our CI checks.

However, our current PR's aren't required to pass CI before being merged:

1. We should change this so they have to pass CI.
2. We need to retain the ability to override in case for some reason a PR intentionally won't pass CI but we still need to merge it. While very rare, this does occasionally happen. Several of the maintainers have admin rights on the repo so they could temporarily disable those branch checks if needed.

[a-ungurianu]

I agree with this, but I feel like fixing/ignoring the intermittent tests is a pre requisite for this

[ceache]

Agreed!

…

On Sat, Jan 21, 2023, 15:03 Jeff Widman ***@***.***> wrote: In #652 <#652>, @StephenSorriaux <https://github.com/StephenSorriaux> very nicely fixed up our CI checks. However, our current PR's aren't required to pass CI before being merged: 1. We should change this so they have to pass CI. 2. We need to retain the ability to override in case for some reason a PR intentionally won't pass CI but we still need to merge it. While very rare, this does occasionally happen. That means at least one (preferably two) of the *currently active* maintainers should have admin rights on the repo so they could temporarily disable those branch checks if needed. — Reply to this email directly, view it on GitHub <#698>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIFTHVSZ7ATKWJNIQQGP63WTQ6K3ANCNFSM6AAAAAAUCSCDS4> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>