Skip to content

gh-134262: increase retries in Tools/build/generate_sbom.py #134558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented May 23, 2025

  • Increase max retry count to 7
  • Increase base of exponential backoff to 2.25
  • Add jitter in case there is some issue with sending requests at the same time
  • Also print the location that fails

The retry backoff now ranges from 1 second to 130 seconds.

- Increase max retry count to 7
- Increase base of exponential backoff to 2.25
- Add jitter in case there is some issue with sending requests at the
  same time
- Also print the location that fails
@emmatyping emmatyping requested a review from sethmlarson as a code owner May 23, 2025 02:19
@emmatyping emmatyping requested a review from hugovk May 23, 2025 02:19
@emmatyping emmatyping added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 23, 2025
@picnixz picnixz changed the title gh-134262: Retry retries more gh-134262: increase retries in Tools/build/generate_sbom.py May 23, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit 3f9eb55 into python:main May 27, 2025
58 checks passed
@miss-islington-app
Copy link

Thanks @emmatyping for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @emmatyping and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3f9eb55e090a8de80503e565f508f341c5f4c8da 3.14

@miss-islington-app
Copy link

Sorry, @emmatyping and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3f9eb55e090a8de80503e565f508f341c5f4c8da 3.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants