-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-130655: add tests for dgettext #134594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex-semenyuk
wants to merge
3
commits into
python:main
Choose a base branch
from
alex-semenyuk:add_dgettext_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ | |
|
||
|
||
# TODO: | ||
# - Add new tests, for example for "dgettext" | ||
# - Tests should have only one assert. | ||
|
||
GNU_MO_DATA = b'''\ | ||
|
@@ -937,6 +936,42 @@ def test_lazy_import(self): | |
ensure_lazy_imports("gettext", {"re", "warnings", "locale"}) | ||
|
||
|
||
class DGettextTest(unittest.TestCase): | ||
|
||
def setUp(self): | ||
self.localedir = self.enterContext(os_helper.temp_dir()) | ||
self.domain = 'gettext_domain' | ||
self.mofile = self.setup_dgettext_test_env() | ||
|
||
def setup_dgettext_test_env(self): | ||
os.makedirs(os.path.join(self.localedir, 'en', 'LC_MESSAGES'), exist_ok=True) | ||
mofile = os.path.join(self.localedir, 'en', 'LC_MESSAGES', f'{self.domain}.mo') | ||
with open(mofile, 'wb') as fp: | ||
fp.write(b'\x00\x00\x00\x00') | ||
return mofile | ||
|
||
def test_dgettext_found_translation(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Join this one with the other two, these all test the exact same thing (which is well tested above too). |
||
gettext.bindtextdomain(self.domain, self.localedir) | ||
with unittest.mock.patch('gettext.dgettext') as mock_dgettext: | ||
mock_dgettext.return_value = 'test message translation' | ||
result = gettext.dgettext(self.domain, 'test message') | ||
self.assertEqual(result, 'test message translation') | ||
|
||
def test_dgettext_missing_translation(self): | ||
gettext.bindtextdomain(self.domain, self.localedir) | ||
result = gettext.dgettext(self.domain, 'missing message') | ||
self.assertEqual(result, 'missing message') | ||
|
||
def test_dgettext_non_existent_domain(self): | ||
result = gettext.dgettext('nonexistent_domain', 'test message') | ||
self.assertEqual(result, 'test message') | ||
|
||
def test_dgettext_empty_domain(self): | ||
result = gettext.dgettext('', 'test message') | ||
expected = gettext.gettext('test message') | ||
self.assertEqual(result, expected) | ||
alex-semenyuk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
if __name__ == '__main__': | ||
unittest.main() | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the TODO, since it is still valid (the first part).
It can be updated with the issue number if you wish.