Skip to content

gh-134717: Allow overriding serialization of NaN and Infinity in json.encoder #134715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krzyszti
Copy link

@krzyszti krzyszti commented May 26, 2025

This change modifies the json.encoder module to permit customization of how special floating-point values (NaN, Infinity, -Infinity) are serialized. By introducing a floatstr function, developers can now define alternative representations for these values, such as null, 0, or custom strings, enhancing flexibility in JSON output.

This change can allow the programmer to override Nan/Infinity/-Infinity to be not only NaN but null, 0 or whatever they want it to be.
@python-cla-bot
Copy link

python-cla-bot bot commented May 26, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@krzyszti krzyszti changed the title gh-112517: Allow overriding serialization of NaN and Infinity in json.encoder gh-134717: Allow overriding serialization of NaN and Infinity in json.encoder May 26, 2025
@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krzyszti
The news entry here is in the wrong place and format. Please move it to /next/Library/ and use blurb or blurb it to create the entry. The content {of the news entry} looks fine though

Copy link
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self isn't defined here either

@nineteendo
Copy link
Contributor

Also keep in mind that the C implementation will still be called if you override floatstr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants