Skip to content

gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future. #134734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented May 26, 2025

@ericvsmith ericvsmith changed the title gh-134675: Add t-string prefixes to tokenizer module, and add a test to make sure we catch this error in the future. gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future. May 26, 2025
@ericvsmith ericvsmith merged commit 08c78e0 into python:main May 26, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2025
…nalysis doc, and add a test to make sure we catch this error in the future. (pythonGH-134734)

* Add t-string prefixes to _all_string_prefixes, and add a test to make sure we catch this error in the future.

* Update lexical analysis docs for t-string prefixes.
(cherry picked from commit 08c78e0)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@ericvsmith ericvsmith deleted the issue-134675 branch May 26, 2025 17:49
@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

GH-134739 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
ericvsmith added a commit that referenced this pull request May 26, 2025
…analysis doc, and add a test to make sure we catch this error in the future. (GH-134734) (#134739)

gh-134675: Add t-string prefixes to tokenizer module, lexical analysis doc, and add a test to make sure we catch this error in the future. (GH-134734)

* Add t-string prefixes to _all_string_prefixes, and add a test to make sure we catch this error in the future.

* Update lexical analysis docs for t-string prefixes.
(cherry picked from commit 08c78e0)

Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@ericvsmith
Copy link
Member Author

See #134752 for improving the performance of the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 bugs and security fixes skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant